From owner-svn-src-all@FreeBSD.ORG Sat Feb 7 05:23:49 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8B5AC59A; Sat, 7 Feb 2015 05:23:49 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 510D5859; Sat, 7 Feb 2015 05:23:49 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id ey11so21594905pad.7; Fri, 06 Feb 2015 21:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=2IK82kPHd0ImURt1advKpEq3nSZNQCNhPTSUs0eQ+r4=; b=XKcg168lXo394Tfts/czyDJCSjaPwgOkrTVMEr4lZZaaJHOaI4e3ALmyBBQ/5og0zv fMriTA6LWs6YuHQBV7xeOIJs2kH96Ob6KIzm4MyfsB8XNmSSqA09k90lBWxFhuqXLlvV 4dt3loPfPlyQ5AMCdKcSNoCyUp3SYFcOc1I+/vu99nb8bzIS6uUsU1a65GS3+CsflebE OgRzqbIT+5do4PBBNFL7gAXQKkrv6anMhJGZe1Zoi5n28TL3Ic2WDUY9HLCeWYYwNX0D oxyVN+L9pdERhXPe9bNrJ98ktmf0M9gE0oRj4Ne0xbGg9Dr/l198R+LtWKlkB9Zl03R3 bgVw== X-Received: by 10.70.45.108 with SMTP id l12mr11147662pdm.112.1423286628827; Fri, 06 Feb 2015 21:23:48 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:e47d:5c02:fe5f:40fa? ([2601:8:ab80:7d6:e47d:5c02:fe5f:40fa]) by mx.google.com with ESMTPSA id uy8sm9694106pbc.31.2015.02.06.21.23.47 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Feb 2015 21:23:48 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r278323 - in head: etc/rc.d usr.sbin/jail From: Garrett Cooper In-Reply-To: Date: Fri, 6 Feb 2015 21:23:47 -0800 Message-Id: References: <201502061754.t16HssXU042750@svn.freebsd.org> <343803A3-CFA3-4766-8294-139A6D8C0235@gmail.com> To: James Gritton X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , jenkins-admin@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2015 05:23:49 -0000 --Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Feb 6, 2015, at 18:38, James Gritton wrote: > On 2015-02-06 19:23, Garrett Cooper wrote: >> On Feb 6, 2015, at 9:54, Jamie Gritton wrote: >>> Author: jamie >>> Date: Fri Feb 6 17:54:53 2015 >>> New Revision: 278323 >>> URL: https://svnweb.freebsd.org/changeset/base/278323 >>> Log: >>> Add mount.procfs jail parameter, so procfs can be mounted when a = prison's >>> root is in its fstab. >>> Also fix a typo while I'm at it. >>> PR: 197237 197066 >>> MFC after: 3 days >>> Modified: >>> head/etc/rc.d/jail >>> head/usr.sbin/jail/command.c >>> head/usr.sbin/jail/config.c >>> head/usr.sbin/jail/jail.8 >>> head/usr.sbin/jail/jail.c >>> head/usr.sbin/jail/jailp.h >> I think you broke the Jenkins tests runs, and potentially jail = support >> in some edgecases: >> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/651/ >=20 > Where do I go from here? There error you refer to certainly seems = jail-related, which leads me to guess at something disconnected between = the matching rc.d/jail and jail(8) change (i.e. using the new rc file = with the old jail program). But that's really just a wild guess. Is = there somewhere I look for more information? For example, where does = Jenkins actually do its thing? >=20 > Sorry for being so stupid in this - Jenkins has only been on the very = edge of my awareness until now. I honestly don=92t think it=92s Jenkins because Jenkins runs in bhyve. I = think you accidentally broke option handling in the jail configuration = (please see my other reply about added =93break;=94 statements). pgrep uses /proc to determine whether or not a process is running. If = it=92s not properly mounted or the jail isn=92t started properly, that = could cause the issues seen here. I know because I=92ve tried running = these tests before in an attempt to fix them, and this was one of the = things I ran into. You can verify your changes by doing: % (cd /usr/tests/bin/pkill; sudo kyua test) Cheers! --Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU1aFjAAoJEMZr5QU6S73eXuIH/0ed5GkSgmfhXVqhi6at1hv6 F2g+49WPImwt7ZHIGhbwcyzaRC9SLRzwQp87c/NqjWhUcAoK8JUl5mQ+pmzjD1B9 UajjttxhRDCCvGTt+RYfGNCoiMexXZdOmrdaLJ4PoKQEJSK0lSKgDImHz7KmTqdH uCDrHYciLbUQA1evOf6Tu0YussW7V82lYZopBa0vICNiWunAw6A1yZlYiZNZZfgT eu6u3Yqfomtb/56K8waSYJOptaMyEsgKtNHyKD3Wk7ZgVnGtnMZp32vyLzUJ+vIE dl7XySLjvFuXiTw6PAmRoseKuZfT0HOqak7UqC++4S5EDH++lKsYb5sVXxqWXRE= =JYG/ -----END PGP SIGNATURE----- --Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25--