From owner-svn-ports-all@FreeBSD.ORG Wed Sep 25 16:47:01 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7758F9F2 for ; Wed, 25 Sep 2013 16:47:01 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4CC892301 for ; Wed, 25 Sep 2013 16:47:01 +0000 (UTC) Received: by mail-pa0-f51.google.com with SMTP id kp14so80072pab.38 for ; Wed, 25 Sep 2013 09:46:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=CR8hEI/fybD0sHmJ4riheGQ7hN3iLsLNCtSzQarvftc=; b=Q3ACbCcK7sKMzSw2MRx4CXCWzY0F3lCSLCRoBKoV74Pi9HXNIwzCgj1xDzAXW/RekI NF9hoLEpqY6/ooEwoQasIJNrRBfQiclxgLjihnIdT2DDxkdcM7AN29tPPr8NV63z2U2Y SlYqV9l6lIBWmpn27DJI5ovDg8eDD8tvyFn9eL0oashu+iUz1uzUrCUH02/iz1kzW0Rw njqT7hET+iy855CtaSMFa7aZ3dnThPpFf5sWZ71ZSQLkBn8U9jtILmwamBbbieOLqRCw BbLOcLA81Tyew34JK5OoyZrO2Ul3vh5WT6GRhSmdvcczqCDLckESIxdp3d5A4igHkaPe 0aGA== X-Gm-Message-State: ALoCoQkeylVJEUV/YkDBrH1LnbkZ/uk6GmxfhCSIRWsqo2CivtjBiyiOpC8lqhgYu06EWJk6VinN MIME-Version: 1.0 X-Received: by 10.66.145.166 with SMTP id sv6mr175703pab.31.1380127615051; Wed, 25 Sep 2013 09:46:55 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.70.100.165 with HTTP; Wed, 25 Sep 2013 09:46:54 -0700 (PDT) In-Reply-To: References: <201309251631.r8PGVQug087427@svn.freebsd.org> Date: Wed, 25 Sep 2013 09:46:54 -0700 X-Google-Sender-Auth: TmIOx8IwN2wZ9GU5QrCYE5MmKls Message-ID: Subject: Re: svn commit: r328299 - head/games/bubble-chains From: Jason Helfman To: William Grzybowski Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , Rusmir Dusko , Jason Helfman , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2013 16:47:01 -0000 Great, thanks. Additionally, is there any reason why staging isn't being supported in recent commits? -jgh On Wed, Sep 25, 2013 at 9:43 AM, William Grzybowski wrote: > On Wed, Sep 25, 2013 at 1:36 PM, Jason Helfman wrote: > > You removed NO_STAGE, but are not supporting staging. This should be put > > back or fixed. > > Indeed, the patch he sent us did not have NO_STAGE removed, I'll talk to > him. > Sorry about that. > > > On Wed, Sep 25, 2013 at 9:31 AM, Rusmir Dusko > wrote: > >> > >> Author: nemysis > >> Date: Wed Sep 25 16:31:26 2013 > >> New Revision: 328299 > >> URL: http://svnweb.freebsd.org/changeset/ports/328299 > >> > >> Log: > >> - Change Makefile header > >> - Change maintainer email to @FreeBSD.org > >> - Add USE_DOS2UNIX > >> - Change Desktop entry file > >> - Add DOCS Option > >> - Add post-configure, fix build with Clang > >> - Mute dir install > >> > >> Approved by: wg/pawel (mentors) > >> > >> Modified: > >> head/games/bubble-chains/Makefile > >> > >> Modified: head/games/bubble-chains/Makefile > >> > >> > ============================================================================== > >> --- head/games/bubble-chains/Makefile Wed Sep 25 16:05:48 2013 > >> (r328298) > >> +++ head/games/bubble-chains/Makefile Wed Sep 25 16:31:26 2013 > >> (r328299) > >> @@ -1,4 +1,4 @@ > >> -# Created by: nemysis@gmx.ch > >> +# Created by: nemysis > >> # $FreeBSD$ > >> > >> PORTNAME= bubble-chains > >> @@ -9,7 +9,7 @@ MASTER_SITES= http://bubble-chains.sinte > >> DISTNAME= chains-${DISTVERSION} > >> EXTRACT_SUFX= -src.7z > >> > >> -MAINTAINER= nemysis@gmx.ch > >> +MAINTAINER= nemysis@FreeBSD.org > >> COMMENT= The aim is to remove all of the targets on each level > >> > >> LICENSE= GPLv2 > >> @@ -22,17 +22,17 @@ WRKSRC= ${WRKDIR}/chains-${PORTVERSION} > >> USE_SDL= sdl image mixer > >> USE_GL= glut glew glu > >> USE_XORG= xrandr > >> +USE_DOS2UNIX= *.pro *.cpp *.h *.ui *.ui *.rc *.htm *.dat *.css > >> USE_QT4= moc_build qmake_build rcc_build uic_build iconengines > >> imageformats \ > >> corelib svg xml opengl network > >> > >> - > >> PORTDOCS= README > >> > >> -DESKTOP_ENTRIES="Bubble Chains" "${COMMENT}" \ > >> - "${PREFIX}/share/pixmaps/${PORTNAME}.png" \ > >> +DESKTOP_ENTRIES="Bubble Chains" "${COMMENT}" "${PORTNAME}" \ > >> "${PORTNAME}" "Game;ArcadeGame;" false > >> > >> -NO_STAGE= yes > >> +OPTIONS_DEFINE= DOCS > >> + > >> .include > >> > >> P7ZIP_CMD= ${LOCALBASE}/bin/7z > >> @@ -50,6 +50,11 @@ do-configure: > >> @cd ${WRKSRC} && ${SETENV} ${CONFIGURE_ENV} \ > >> ${QMAKE} ${QMAKEFLAGS} PREFIX=${PREFIX} > >> > >> +post-configure: > >> + @${REINPLACE_CMD} -e 's|CFLAGS =|CFLAGS ?=|' \ > >> + -e 's|CXXFLAGS =|CXXFLAGS ?=|' \ > >> + ${WRKSRC}/Makefile > >> + > >> do-install: > >> ${INSTALL_PROGRAM} ${WRKSRC}/bin/chains > ${PREFIX}/bin/${PORTNAME} > >> @(cd ${WRKSRC} && ${COPYTREE_SHARE} data ${DATADIR}) > >> @@ -60,7 +65,7 @@ do-install: > >> ${PREFIX}/share/pixmaps/${PORTNAME}.ico > >> > >> .if ${PORT_OPTIONS:MDOCS} > >> - ${MKDIR} ${DOCSDIR} > >> + @${MKDIR} ${DOCSDIR} > >> ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR} > >> .endif > >> > >> > > > > > > > > -- > > Jason Helfman | FreeBSD Committer > > jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to > Serve > > > > -- > William Grzybowski > ------------------------------------------ > Curitiba/PR - Brasil > > -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve