From owner-cvs-all@FreeBSD.ORG Fri Feb 18 22:53:08 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBD7916A4CE; Fri, 18 Feb 2005 22:53:08 +0000 (GMT) Received: from srv1.cosmo-project.de (srv1.cosmo-project.de [213.83.6.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DD4343D3F; Fri, 18 Feb 2005 22:53:08 +0000 (GMT) (envelope-from ticso@cicely12.cicely.de) Received: from cicely5.cicely.de (cicely5.cicely.de [10.1.1.7]) (authenticated bits=0)j1IMr1wh006773 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK); Fri, 18 Feb 2005 23:53:03 +0100 (CET) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (cicely12.cicely.de [IPv6:3ffe:400:8d0:301::12]) by cicely5.cicely.de (8.12.10/8.12.10) with ESMTP id j1IMqg55062594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 18 Feb 2005 23:52:42 +0100 (CET) (envelope-from ticso@cicely12.cicely.de) Received: from cicely12.cicely.de (localhost [127.0.0.1]) by cicely12.cicely.de (8.12.11/8.12.11) with ESMTP id j1IMqfQ2014920; Fri, 18 Feb 2005 23:52:41 +0100 (CET) (envelope-from ticso@cicely12.cicely.de) Received: (from ticso@localhost) by cicely12.cicely.de (8.12.11/8.12.11/Submit) id j1IMqfcG014919; Fri, 18 Feb 2005 23:52:41 +0100 (CET) (envelope-from ticso) Date: Fri, 18 Feb 2005 23:52:41 +0100 From: Bernd Walter To: Warner Losh Message-ID: <20050218225241.GG14312@cicely12.cicely.de> References: <200502181735.j1IHZ3Ch032038@repoman.freebsd.org> <20050218214654.GD14312@cicely12.cicely.de> <20050218.153509.85367062.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050218.153509.85367062.imp@bsdimp.com> X-Operating-System: FreeBSD cicely12.cicely.de 5.2-CURRENT alpha User-Agent: Mutt/1.5.6i X-Spam-Status: No, hits=0.0 required=3.0 tests=none autolearn=no version=2.64 X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on cicely12.cicely.de cc: ticso@cicely12.cicely.de cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: ticso@cicely.de cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: ticso@cicely.de List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2005 22:53:09 -0000 On Fri, Feb 18, 2005 at 03:35:09PM -0700, Warner Losh wrote: > From: Bernd Walter > Subject: Re: cvs commit: src/sys/dev/pci pci_pci.c > Date: Fri, 18 Feb 2005 22:46:55 +0100 > > > On Fri, Feb 18, 2005 at 05:35:03PM +0000, Warner Losh wrote: > > > imp 2005-02-18 17:35:03 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/pci pci_pci.c > > > Log: > > > For the I/O port case, we need to set ok to 1 if we have what looks > > > like a valid range. We already do this in the memory case (although > > > the code there is somewhat different than the I/o case because we have > > > to deal with different kinds of memory). Since most laptops don't > > > have non-subtractive bridges, this wasn't seen in practice. > > > > Does that mean we do check ranges on pci bridges? > > Yes. And we have been for a long time. Great :-) > > I can remember having troubles with alpha systems where io ranges in > > PCI chips behind PCI-PCI bridges looked valid by themself, but in fact > > no IO range is configured on bridges. > > Yes. And we've been dealing with the newer subtractively decoded > bridges for a long time as well too :-) > > long time == since before 5.3 :-) I think it was much more than a year ago. Just wanted to check up if it's worth testing again. Unfortunately I just removed the bridged cards from the test box. -- B.Walter BWCT http://www.bwct.de bernd@bwct.de info@bwct.de