From owner-svn-src-all@freebsd.org Fri Oct 18 12:00:50 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E95114E595; Fri, 18 Oct 2019 12:00:50 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vl3h6HM7z4TVX; Fri, 18 Oct 2019 12:00:48 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x441.google.com with SMTP id l10so5556022wrb.2; Fri, 18 Oct 2019 05:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=Fb3Qby4PLx8rMvhIkir0Z7U7ySyaF0qbX9sSKBCVSdg=; b=e51OOWw0OjumnJ6TUyG9xC1zLFv5Fj8gRnIyJW7CdrKpSL/Q6CeYSYr2fMhRAYvy5I 5jlu6K59HiojaRn1PPtU4nbLUjZBOaxYQpvF5nHx00E0jRDXHM25EYyS88nU3YQ9RB27 zF8a72zvzkrbSnC5Hoz2D/R9WCzEVBXmR6SZgFOJsJRrQaU8IJkIgiUD7fw+6T2XsKx+ tX0VRQKx2Wnxy2feOpB2RKittIH/zCN2UUbBs0Hm3GlEriU6naKKkoClcHGB9f9PLeZ4 BVFwN0HrsIux1+3FDQGP6eklDvxKHE9pQpsDYwzZpj8E7PycqZJTgZ83Mv/WyUpTxV8+ hh6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=Fb3Qby4PLx8rMvhIkir0Z7U7ySyaF0qbX9sSKBCVSdg=; b=JdYInxsf+gwHNFZdqsKJeG38bj0pb/B/6Dv2dTWSv/O52/r00+UMqCBlO7FtIW+X0x OH863dN6qbXdpjFfSNpjguLWh0X/LSj4wKafhouMqfWpox1gqk2kU3Pmi47wYkdU2QwF 59DxbSZssm4r1rhC4N7PgK3juHFjBaS2j7u04kfRZn4ywgerE3iTudO+lJeNnHpPUWlb vPSXalTt8RcfPusBkPn6GdLEeitovxnrDNqjwz2A7Vo74j1SOatgV5+pgbfwefnQ7pDR WVAWAvlE7t6b2DkPTTecHMdwYzr7luovUTUQRScPf54TE53rdHNKmQ6W+cDbZ9N7XWU+ SjHw== X-Gm-Message-State: APjAAAW/2Y3sNrCWbhDp5J2vpSee7qBbZQ2qWp9psQ5anECvDGYUAQCU 1UTpM9jF/OMVhbliOmb3v5M= X-Google-Smtp-Source: APXvYqxMBD7EEQ2HfDbAmiPwY/BPPtFGQ0N4zYP2BfjEkG+Ra8AX0Ju4WvuHIkzS4kgtHWqxfsE2+Q== X-Received: by 2002:adf:dec9:: with SMTP id i9mr7274662wrn.230.1571400047041; Fri, 18 Oct 2019 05:00:47 -0700 (PDT) Received: from ernst.home (p5B3BE71A.dip0.t-ipconnect.de. [91.59.231.26]) by smtp.gmail.com with ESMTPSA id p12sm5866552wrm.62.2019.10.18.05.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 05:00:46 -0700 (PDT) Date: Fri, 18 Oct 2019 14:00:45 +0200 From: Gary Jennejohn To: "Hartmann, O." Cc: Conrad Meyer , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r353700 - in head: share/man/man4 sys/amd64/conf sys/conf sys/gdb sys/i386/conf sys/kern sys/net sys/sys Message-ID: <20191018140045.31d269b0@ernst.home> In-Reply-To: <20191018122104.389ffb7a@hermann.fritz.box> References: <201910172133.x9HLX1kl071044@repo.freebsd.org> <20191018122104.389ffb7a@hermann.fritz.box> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46vl3h6HM7z4TVX X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=e51OOWw0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::441 as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RECEIVED_SPAMHAUS_PBL(0.00)[26.231.59.91.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (2.77), ipnet: 2a00:1450::/32(-2.84), asn: 15169(-2.09), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 12:00:50 -0000 On Fri, 18 Oct 2019 12:21:04 +0200 "Hartmann, O." wrote: > On Thu, 17 Oct 2019 21:33:01 +0000 (UTC) > Conrad Meyer wrote: > > > Author: cem > > Date: Thu Oct 17 21:33:01 2019 > > New Revision: 353700 > > URL: https://svnweb.freebsd.org/changeset/base/353700 > > > > Log: > > Implement NetGDB(4) > > > > NetGDB(4) is a component of a system using a panic-time network > > stack to remotely debug crashed FreeBSD kernels over the network, > > instead of traditional serial interfaces. > > > > There are three pieces in the complete NetGDB system. > > > > First, a dedicated proxy server must be running to accept > > connections from both NetGDB and gdb(1), and pass bidirectional > > traffic between the two protocols. > > > > Second, the NetGDB client is activated much like ordinary 'gdb' and > > similarly to 'netdump' in ddb(4) after a panic. Like other > > debugnet(4) clients (netdump(4)), the network interface on the route > > to the proxy server must be online and support debugnet(4). > > > > Finally, the remote (k)gdb(1) uses 'target remote :' > > (like any other TCP remote) to connect to the proxy server. > > > > The NetGDB v1 protocol speaks the literal GDB remote serial > > protocol, and uses a 1:1 relationship between GDB packets and > > sequences of debugnet packets (fragmented by MTU). There is no > > encryption utilized to keep debugging sessions private, so this is > > only appropriate for local segments or trusted networks. > > > > Submitted by: John Reimer (earlier > > version) Discussed some with: emaste, markj > > Relnotes: sure > > Differential Revision: https://reviews.freebsd.org/D21568 > > > > Added: > > head/share/man/man4/netgdb.4 (contents, props changed) > > head/sys/gdb/netgdb.c (contents, props changed) > > head/sys/gdb/netgdb.h (contents, props changed) > > Modified: > > head/share/man/man4/Makefile > > head/share/man/man4/ddb.4 > > head/sys/amd64/conf/GENERIC > > head/sys/conf/NOTES > > head/sys/conf/files > > head/sys/conf/options > > head/sys/gdb/gdb.h > > head/sys/gdb/gdb_int.h > > head/sys/gdb/gdb_main.c > > head/sys/gdb/gdb_packet.c > > head/sys/i386/conf/GENERIC > > head/sys/kern/subr_kdb.c > > head/sys/net/debugnet.c > > head/sys/net/debugnet.h > > head/sys/net/debugnet_inet.c > > head/sys/net/debugnet_int.h > > head/sys/sys/kdb.h > > head/sys/sys/param.h > > > > Modified: head/share/man/man4/Makefile > > ============================================================================== > > --- head/share/man/man4/Makefile Thu Oct 17 21:25:50 > > 2019 (r353699) +++ head/share/man/man4/Makefile Thu Oct > > 17 21:33:01 2019 (r353700) @@ -307,6 +307,7 @@ MAN= > > aac.4 \ net80211.4 \ > > netdump.4 \ > > netfpga10g_nf10bmac.4 \ > > + netgdb.4 \ > > netgraph.4 \ > > netintro.4 \ > > netmap.4 \ > > > [...] > > > Having "nooptions NETGDB # netgdb(4) client support" > defined in my kernel config file, buildkernel fails with the error > shown below. > > [...] > --- debugnet.o --- > /usr/src/sys/net/debugnet.c:662:4: error: implicit declaration of > function 'db_printf' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] db_printf("%s: Could not get > route for that server.\n", ^ /usr/src/sys/net/debugnet.c:662:4: note: > did you mean 'if_printf'? /usr/src/sys/net/if_var.h:679:5: note: > 'if_printf' declared here int if_printf(struct ifnet *, const char > *, ...) __printflike(2, 3); ^ > 1 error generated. And I also had to add "nooptions NETDUMP" to get the kernel to compile and link. -- Gary Jennejohn