Date: Mon, 1 May 2023 15:58:10 +0100 From: Alexander Chernikov <melifaro@FreeBSD.org> To: Renato Botelho <garga@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 6a09a7f1e9a5 - main - netlink: always zero provided header buffers. Message-ID: <7CBFB961-B052-4F95-BE04-8865D9B49034@FreeBSD.org> In-Reply-To: <58128e85-82e3-e529-2d65-1145e6c84c09@FreeBSD.org> References: <202305011409.341E9wop057673@gitrepo.freebsd.org> <58128e85-82e3-e529-2d65-1145e6c84c09@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 1 May 2023, at 15:30, Renato Botelho <garga@freebsd.org> wrote: >=20 > On 01/05/23 11:09, Alexander V. Chernikov wrote: >> The branch main has been updated by melifaro: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6a09a7f1e9a52fb25158ca60216c6b81= 7f8c0b71 >> commit 6a09a7f1e9a52fb25158ca60216c6b817f8c0b71 >> Author: Alexander V. Chernikov <melifaro@FreeBSD.org> >> AuthorDate: 2023-05-01 14:07:33 +0000 >> Commit: Alexander V. Chernikov <melifaro@FreeBSD.org> >> CommitDate: 2023-05-01 14:09:47 +0000 >> netlink: always zero provided header buffers. >> Reported by: KMSAN >> MFC after: 3 days >> --- >> sys/netlink/netlink_message_writer.h | 1 + >> sys/netlink/route/neigh.c | 3 --- >> 2 files changed, 1 insertion(+), 3 deletions(-) >> diff --git a/sys/netlink/netlink_message_writer.h = b/sys/netlink/netlink_message_writer.h >> index 57fc1bf342ea..92e43834efc7 100644 >> --- a/sys/netlink/netlink_message_writer.h >> +++ b/sys/netlink/netlink_message_writer.h >> @@ -225,6 +225,7 @@ nlmsg_reserve_data_raw(struct nl_writer *nw, = size_t sz) >> void *data_ptr =3D &nw->data[nw->offset]; >> nw->offset +=3D sz; >> + bzero(data_ptr, sz); >=20 > At first look, this line seems to be indented wrong. But looking at = cgit web interface it seems that other lines are wrong and this is = correct. Ups. Somehow I messed with spaces. Thanks for pointing this out! Should = be fixed by 88406e631e93. /Alexander > --=20 > Renato Botelho >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7CBFB961-B052-4F95-BE04-8865D9B49034>