From owner-svn-src-all@freebsd.org Fri Nov 13 21:24:47 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9089A2EEC2 for ; Fri, 13 Nov 2015 21:24:47 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [IPv6:2607:f8b0:400e:c03::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F5481434 for ; Fri, 13 Nov 2015 21:24:47 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by padhx2 with SMTP id hx2so111213698pad.1 for ; Fri, 13 Nov 2015 13:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=vH4UMNY+JKG3cK7sc2fVn7iJ7MaWz2apBIJJRtQ3QZ4=; b=MGcWp2toIDh1kbvAbo1oZrUOeMew/yqVAgjUEaamEKxZNd9JVJDQlhmJ5DPFYyOXeb oiaFdrqoMX8bXJN3sTGOiyAR2hkoB4iljHllxAxjcd2SSvLbkv3K4qDh1nPuz6tjIo99 e/c5tiwsUod2RsYoDlQtV3u/dRYdD1ZGiBMSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=vH4UMNY+JKG3cK7sc2fVn7iJ7MaWz2apBIJJRtQ3QZ4=; b=cjpbQlEfjLhBG8UuvwuQiR45k9hk3xU2hIaIgGXzG5dw6ICOyosB8GuPX5YhI3Wvtv Dj/Ju0ndigGBODPrGaDdRS47Ig2btX+80zBvY1/YM7RZiBeqYRI6yh2J3DGjP9zrNRZ7 waVPAA2SB8W7vpvbBdVL9hkh57x8VU/OVbDf2qpXiPG2lpCwUYSMxURcJ+IOlAHMvxfk Dmt9DIfE2J2N0NBLK8N+V35bq9FBUkq3wqt8q42e4ooZ8ON3KwxH/NptaMaS+fwWEbq8 kQhnbv37BjOcQE0zMUyRqp/xMuvoLp29q9aIgEx1szT9VlJgEIhdTVKhOyPKnHMfHYB9 5hzQ== X-Gm-Message-State: ALoCoQmbPPvs4cF6pN0UyQXf+eKqMTZ4AjTdMCHNGzGygrRis6VR026My8MYJ9rHqcFrwD5bYNqJ X-Received: by 10.66.194.16 with SMTP id hs16mr11013581pac.93.1447449887076; Fri, 13 Nov 2015 13:24:47 -0800 (PST) Received: from ip-192-168-70-10.us-west-2.compute.internal ([69.53.245.107]) by smtp.gmail.com with ESMTPSA id ux3sm22217266pac.18.2015.11.13.13.24.44 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Nov 2015 13:24:45 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys From: Randall Stewart In-Reply-To: <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> Date: Fri, 13 Nov 2015 16:24:47 -0500 Cc: "Alexander V. Chernikov" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org Message-Id: References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <56465003.8070709@FreeBSD.org> <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> To: Bryan Drewery X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 21:24:47 -0000 Looking at the patch, we need a define of your _callout_stop_safe and we need to switch callout_stop()=92s define to use the new _callout_stop_safe() R On Nov 13, 2015, at 4:20 PM, Randall Stewart wrote: > No alexander=92s panic=92s are because the > LLREF > is done if (callout_stop()) >=20 > But now if it was not running -1 is returned.. >=20 > Try the patch I just sent.. >=20 > R > On Nov 13, 2015, at 4:02 PM, Bryan Drewery = wrote: >=20 >> On 11/13/2015 1:00 PM, Randall Stewart wrote: >>> Bryan: >>>=20 >>> This looks like a decent thing to do.. >>>=20 >>> Still wondering why changing the callout.h header file would not = have caused >>> things to recompile to pick up the new argument.. >>>=20 >>> We can do it this way though it looks fine. >>>=20 >>> You want to commit it or I? >>=20 >> Well your change is totally safe for compiling. It's just not KBI >> backwards compat for older modules. This is not typically a problem = but >> I think in this case it is worth doing to avoid random data coming = into >> the 'drain' argument if loading an older module. >>=20 >> I'll do a test build and commit it. Perhaps this is what was leading = to >> Alexander's panics. >>=20 >> I haven't analyzed the return value issue at all. >>=20 >>=20 >> --=20 >> Regards, >> Bryan Drewery >>=20 >=20 > -------- > Randall Stewart > rrs@netflix.com > 803-317-4952 >=20 >=20 >=20 >=20 >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952