From owner-svn-src-all@freebsd.org Sat Jul 11 14:16:43 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C07B19987B9; Sat, 11 Jul 2015 14:16:43 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: from mail-yk0-x22f.google.com (mail-yk0-x22f.google.com [IPv6:2607:f8b0:4002:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C7172D30; Sat, 11 Jul 2015 14:16:43 +0000 (UTC) (envelope-from crodr001@gmail.com) Received: by ykax123 with SMTP id x123so36307109yka.1; Sat, 11 Jul 2015 07:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+EaKDjIt8Uitd0doqgwjFiogboNzKywocGSUBTdeKRw=; b=WLt20/9DcDxw1I8IhRJ1PfxTTHFgpRbFitBBtXWiLtLxKWjmqMse/Tb0celjw+YLZU q13TyPJFfllLZXW+QOQI21phnNjiqknPvqNcXFPvpxOdUV5QFWejVMlfk/HYxd4CWZlD cl4oYXd6qnNJVIgVdDRcJBV9kpA9sbXJAmlOiWDJl7BYLdnlTF8MuJ+eal3FqYwtwSdr cUTTb77xLgoxGa9SjNy38j+ijB3eFMGPpCEu07JYM0/5U7QnbStsSuz+JgBns6qH9FvT XNzcNzdrMCHS+4DKtMESl5T1z+KBgAt24QGiQMqkcdHH1dkPHY93tK5P6Yog/axp8Lrs B27A== MIME-Version: 1.0 X-Received: by 10.170.36.197 with SMTP id 188mr14866463yke.10.1436624202121; Sat, 11 Jul 2015 07:16:42 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.37.11.70 with HTTP; Sat, 11 Jul 2015 07:16:42 -0700 (PDT) In-Reply-To: <20150711080439.GD8523@funkthat.com> References: <201507110312.t6B3CZBv081280@repo.freebsd.org> <20150711080439.GD8523@funkthat.com> Date: Sat, 11 Jul 2015 10:16:42 -0400 X-Google-Sender-Auth: IjBQg-b5l58ki7EMaMr0Zx2xx5E Message-ID: Subject: Re: svn commit: r285366 - in head: lib/libmd sys/crypto/sha2 From: Craig Rodrigues To: John-Mark Gurney Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2015 14:16:43 -0000 On Sat, Jul 11, 2015 at 4:04 AM, John-Mark Gurney wrote: > > This change breaks upgrading from 10-stable... I'm not sure why it > In my FreeBSD 10.1-RELEASE VM, I am seeing this: --- xinstall --- cc -O2 -pipe -I/builds/FreeBSD_HEAD/usr.bin/xinstall/../../contrib/mtree -I/builds/FreeBSD_HEAD/usr.bin/xinstall/../../lib/libnetbsd -I/builds/FreeBSD_HEAD/usr.bin/xinstall/../../lib/libmd -std=gnu99 -Qunused-arguments -I/builds/FreeBSD_HEAD/obj/builds/FreeBSD_HEAD/tmp/legacy/usr/include -static -L/builds/FreeBSD_HEAD/obj/builds/FreeBSD_HEAD/tmp/legacy/usr/lib -o xinstall xinstall.o getid.o -lmd -legacy xinstall.o: In function `install': /builds/FreeBSD_HEAD/usr.bin/xinstall/xinstall.c:(.text+0x133c): undefined reference to `_libmd_SHA256_File' /builds/FreeBSD_HEAD/usr.bin/xinstall/xinstall.c:(.text+0x1631): undefined reference to `_libmd_SHA256_End' /builds/FreeBSD_HEAD/usr.bin/xinstall/xinstall.c:(.text+0x186c): undefined reference to `_libmd_SHA256_File' xinstall.o: In function `compare': /builds/FreeBSD_HEAD/usr.bin/xinstall/xinstall.c:(.text+0x2706): undefined reference to `_libmd_SHA256_End' cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [xinstall] Error code 1 In the build tree, I see the following libmd.a files created under the obj tree: ./world32/builds/FreeBSD_HEAD/lib/libmd/libmd.a ./tmp/builds/FreeBSD_HEAD/lib/libmd/libmd.a ./tmp/legacy/usr/lib/libmd.a ./lib/libmd/libmd.a If I look for the _libmd_SHA256_File or _libmd_SHA512_File symbols in each library, I see: # for l in $(find . -name "libmd.a") ; do printf "$l\n=======\n"; nm $l | egrep 'SHA256_File|SHA512_File' done ./world32/builds/FreeBSD_HEAD/lib/libmd/libmd.a ======= 00000090 W SHA512_File 000000d0 W SHA512_FileChunk 00000090 T _libmd_SHA512_File 000000d0 T _libmd_SHA512_FileChunk 00000090 W SHA256_File 000000d0 W SHA256_FileChunk 00000090 T _libmd_SHA256_File 000000d0 T _libmd_SHA256_FileChunk ./tmp/builds/FreeBSD_HEAD/lib/libmd/libmd.a ======= 0000000000000080 W SHA512_File 0000000000000090 W SHA512_FileChunk 0000000000000080 T _libmd_SHA512_File 0000000000000090 T _libmd_SHA512_FileChunk U _libmd_SHA256_FileChunk ./tmp/legacy/usr/lib/libmd.a ======= 0000000000000080 W SHA512_File 0000000000000090 W SHA512_FileChunk 0000000000000080 T _libmd_SHA512_File 0000000000000090 T _libmd_SHA512_FileChunk U _libmd_SHA256_FileChunk ./lib/libmd/libmd.a ======= 00000000000000b0 W SHA512_File 00000000000000c0 W SHA512_FileChunk 00000000000000b0 T _libmd_SHA512_File 00000000000000c0 T _libmd_SHA512_FileChunk 00000000000000a0 W SHA256_File 00000000000000b0 W SHA256_FileChunk 00000000000000a0 T _libmd_SHA256_File 00000000000000b0 T _libmd_SHA256_FileChunk So it looks like _libmd_SHA256_File is not defined in the legacy library used during the bootstrap. -- Craig