From owner-svn-ports-all@freebsd.org Fri Sep 15 17:18:32 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57E98E23924; Fri, 15 Sep 2017 17:18:32 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 20A926FF12; Fri, 15 Sep 2017 17:18:32 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-24-163-43-246.nc.res.rr.com [24.163.43.246]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id v8FHIKgs061889 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 15 Sep 2017 17:18:26 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r449798 - head/net-mgmt/collectd5 To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201709131455.v8DEtjVq069144@repo.freebsd.org> <305b87d4-297e-e569-7011-9c322984206d@FreeBSD.org> <8660cki73w.fsf@desk.des.no> From: Steve Wills Message-ID: <13547d29-d79f-1b13-ac1e-bd6e8c20be8e@FreeBSD.org> Date: Fri, 15 Sep 2017 13:18:16 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <8660cki73w.fsf@desk.des.no> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Fri, 15 Sep 2017 17:18:27 +0000 (UTC) X-Spam-Status: No, score=1.3 required=4.5 tests=RCVD_IN_RP_RNBL autolearn=no autolearn_force=no version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 17:18:32 -0000 Hi, On 09/15/2017 06:33, Dag-Erling Smørgrav wrote: > Steve Wills writes: >> I'm happy to see more options enabled by default in this port, thanks >> for that. We do have a policy that packaged binaries should be >> stripped. Enabling the DEBUG option by default would seem to be at >> odds with that policy to me. Could you please turn that one off by >> default? > > # file /usr/local/sbin/collectd > /usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 11.0 (1100122), FreeBSD-style, stripped > Hmm, mine built after this change shows: /usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.0 (1200042), FreeBSD-style, not stripped > The DEBUG option enables log messages which are indispensable when > troubleshooting a collectd installation (or rather, makes an additional > log level available). I didn't realize that it also disables stripping. > If that is the case, it needs to be split in two, or maybe the relevant > configure argument should simply be hardcoded. Simply renaming the DEBUG option to LOGGING seems to avoid the issue: /usr/local/sbin/collectd: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), dynamically linked, interpreter /libexec/ld-elf.so.1, for FreeBSD 12.0 (1200042), FreeBSD-style, stripped Steve