From owner-cvs-all@FreeBSD.ORG  Sat May  3 11:43:21 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D814D37B401; Sat,  3 May 2003 11:43:21 -0700 (PDT)
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DAB9543FAF; Sat,  3 May 2003 11:43:20 -0700 (PDT)
	(envelope-from mark@grondar.org)
Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1])
	by storm.FreeBSD.org.uk (8.12.7/8.12.7) with ESMTP id h43IhBSQ065348;
	Sat, 3 May 2003 19:43:11 +0100 (BST)
	(envelope-from mark@grondar.org)
Received: (from Ugrondar@localhost)h43IhB2M065347;
	Sat, 3 May 2003 19:43:11 +0100 (BST)
X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to
	mark@grondar.org using -f
Received: from grondar.org (localhost [127.0.0.1])h43Ifw8c019903;
	Sat, 3 May 2003 19:41:58 +0100 (BST)	(envelope-from mark@grondar.org)
From: Mark Murray <mark@grondar.org>
Message-Id: <200305031841.h43Ifw8c019903@grimreaper.grondar.org>
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: Your message of "Sat, 03 May 2003 11:22:15 MDT."
             <20030503.112215.02300157.imp@bsdimp.com> 
Date: Sat, 03 May 2003 19:41:58 +0100
Sender: mark@grondar.org
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: markm@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/bin/ls extern.h ls.c print.c util.c src/bin/pax
	ar_io.c ar_subs.c cache.c cpio.c extern.h gen_subs.c getoldopt.c
	options.c pat_rep.c pax.c pax.h src/bin/ps fmt.c src/bin/rcp rcp.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 May 2003 18:43:22 -0000

"M. Warner Losh" writes:
> In message: <200305031639.h43GdYQ4049867@repoman.freebsd.org>
>             Mark Murray <markm@FreeBSD.org> writes:
> :   Fix a bazillion warnings. This makes almost the whole of src/bin/*
> :   WARNS=6, std=c99 clean.
> 
> It would be useful if you'd include what each class of warning was and
> how you fixed it.

Useful, sure. "Hard" is the problem. Much of this is work I did a while
ago and is stuff that I've been carrying for a while (like 2 years!).

The methodology is to turn on max warnings and fix the buggers. :-)
About 70% is const-poisoning. Half the rest is signed/unsigned. The
rest are mixed sweets.

M
--
Mark Murray
iumop ap!sdn w,I idlaH