From owner-freebsd-ports Sat Mar 30 4:37:21 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mail-1.zoominternet.net (mail-1.zoominternet.net [63.67.120.4]) by hub.freebsd.org (Postfix) with SMTP id 9751F37B419 for ; Sat, 30 Mar 2002 04:37:18 -0800 (PST) Received: (qmail 32072 invoked from network); 30 Mar 2002 12:36:38 -0000 Received: from unknown (HELO cvzoom.net) ([24.154.77.151]) (envelope-sender ) by mail-1.zoominternet.net (qmail-ldap-1.03) with SMTP for ; 30 Mar 2002 12:36:38 -0000 Message-ID: <3CA5B156.8050201@cvzoom.net> Date: Sat, 30 Mar 2002 07:36:38 -0500 From: Donn Miller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020322 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Kennaway Cc: ports@freebsd.org Subject: Re: Optimizations and XFree86-4-libraries port References: <3CA45DF1.3020201@cvzoom.net> <20020329093937.G45029@xor.obsecurity.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Kris Kennaway wrote: > The XFree86 code is a bit patchy with its use of CFLAGS. For example, > modules don't seem to get build with the system CFLAGS either. If you > had time to go through and make sure it's getting added everywhere it > would be great. The best way is to put the optimization flags inside our temporary host.def file that gets used during the build. I tried something like the following: $ diff -u scripts/configure.orig scripts/configure --- scripts/configure.orig Sat Mar 30 06:58:52 2002 +++ scripts/configure Sat Mar 30 07:15:04 2002 @@ -72,6 +72,8 @@ echo "#define Freetype2Dir ${LOCALBASE}" >> $LOCALDEF echo "#define FreeBSDBuildXlib YES" >> $LOCALDEF echo "#define FreeBSDBuildXbin NO" >> $LOCALDEF + echo "#define DefaultGcc2i386Opt ${CFLAGS}" >> $LOCALDEF + echo "#define GccWarningOptions -Wall" >> $LOCALDEF HasXdmAuth=YES Strangely, ${CFLAGS} turns out to be NULL during the make configure, but ${LOCALBASE} expands to /usr/local, as it should. So my method won't work: work/xc/config/cf/host.def: #define DefaultGcc2i386Opt #define GccWarningOptions -Wall But if I do make -V CFLAGS configure, I see my CFLAGS that I've set in /etc/make.conf show up. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message