Date: Thu, 9 Jan 2020 22:51:37 +0000 (UTC) From: Ian Lepore <ian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356574 - head/sys/cddl/dev/dtrace/arm Message-ID: <202001092251.009MpbIM046361@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ian Date: Thu Jan 9 22:51:37 2020 New Revision: 356574 URL: https://svnweb.freebsd.org/changeset/base/356574 Log: Remove scary-looking printf output that happens when you kldload dtrace on arm. Replace it with a comment block explaining why the function is empty on 32-bit arm. Modified: head/sys/cddl/dev/dtrace/arm/dtrace_subr.c Modified: head/sys/cddl/dev/dtrace/arm/dtrace_subr.c ============================================================================== --- head/sys/cddl/dev/dtrace/arm/dtrace_subr.c Thu Jan 9 21:50:15 2020 (r356573) +++ head/sys/cddl/dev/dtrace/arm/dtrace_subr.c Thu Jan 9 22:51:37 2020 (r356574) @@ -123,7 +123,18 @@ dtrace_invop_remove(int (*func)(uintptr_t, struct trap void dtrace_toxic_ranges(void (*func)(uintptr_t base, uintptr_t limit)) { - printf("IMPLEMENT ME: dtrace_toxic_ranges\n"); + + /* + * There are no ranges to exclude that are common to all 32-bit arm + * platforms. This function only needs to exclude ranges "... in + * which it is impossible to recover from such a load after it has been + * attempted." -- i.e., accessing within the range causes some sort + * fault in the system which is not handled by the normal arm + * exception-handling mechanisms. If systems exist where that is the + * case, a method to handle this functionality would have to be added to + * the platform_if interface so that those systems could provide their + * specific toxic range(s). + */ } void
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001092251.009MpbIM046361>