From nobody Sat Feb 28 01:44:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fN7Ks61Kvz6TpqQ; Sat, 28 Feb 2026 01:44:49 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fN7Ks5T9pz3BqL; Sat, 28 Feb 2026 01:44:49 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772243089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pawD+ZI0lcu/MNedTwjxFA4gA/OseMJ1aNyPOs3j1do=; b=oFfhtF5jZ+OAhLMaio4L1Gbgp40LYR9tYNHmcADE8IkHjb5A2lsXs+cLs37Jw4Y45HFmgx j8yx3vhJLhThsll57m9BpKOOxdu0oGu3KOgx/YXrBmkKfu/je6bXsONn4DgkF0saUJhMoT WglCEJpdUgguQhfD7dHhgtIVPJSHXsuXz2DOGdj0+18Mc0wHtHDl0aObFFSMHyPHzjTAzk apbY+ACoT9zZ0grbRmcO2SSLb3oOO5Sqt/fsSBhptEoqFHOkBHr1YtGDML34xb+NhMW+mg lPWtKS8cU0YcP3ZSFdoC9QwxrmNSe55yvtYlZR/oxIMUKj022ZXX26YaeSvnSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772243089; a=rsa-sha256; cv=none; b=n+wsFExVskRFHkBealDMTi3IcroYYMapsuGP4wc9CDu68UlRngdT2Igfse4iVwOgzcxt48 8lnFFo8PgnOS/IS7IFsNHm2PRWkWHcudKO1XYyCWKHZRVoqwRfRZPYRR7N/f6nk1vRb1bt 5cutwu3BRdlPlsJ3Po8zshZzUg3tIwuqM5Vb675rabFMmUPCj6BdcOdQX0P17xp0JI4OCw 9+2H/FufMImUolx4rc30WOjsEEnkCSVXGxQYmOkgmY+82zJ0RORMAfx0QozSRul5VIhtOv /Gv8wDdfMJf2vMxDZtRqIUp16l9v0KO8cGaAVDv6fQ1jvNq+FQLh3P5EqrzEog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772243089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pawD+ZI0lcu/MNedTwjxFA4gA/OseMJ1aNyPOs3j1do=; b=KseI8jLUmtnDG5Se65nRtRkrxb2VQZjWooSD6bZNAjC72AMS/XRBwTmHFVJAR7AmEvqmXu SL7/2+iiNkTGEkINGhaxhCP+pME3xh7mFmhXSqRCul64spdyZII/CdbUDFdETaLObNVuMP wCq6tD4j+hUMitPncC3Mo/+r+5t9xbKc/gwhlflS0j9TtMQ/U1vzQ2M95TrODfXJ8e9yPQ KCst5+JnRc5P+aPU0InnoleQeWrcsne9DgHoy+oXgsMyj3B0P8Goo1ZQbPVHCk0fjg0IdB aIRs8gAeURI/DrkqvjfDDEi8tcE1i+3yXUsL6YUbRTPRtxXwz5+124gXZ+uJfg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fN7Ks0BghzZ9Q; Sat, 28 Feb 2026 01:44:48 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Fri, 27 Feb 2026 17:44:45 -0800 From: Gleb Smirnoff To: Michael Tuexen Cc: "Enji Cooper (yaneurabeya)" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 454212b9718b - main - sctp: fix so_proto when peeling off a socket Message-ID: References: <699ef25d.42e41.7579887f@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Feb 27, 2026 at 08:11:39AM +0100, Michael Tuexen wrote: M> >> - so = sopeeloff(head); M> >> + so = sopeeloff(head, &sctp_stream_protosw); M> > M> > This part of the change broke LINT-NOINET because sctp_stream_protosw is only defined in the INET case. I didn’t dig into the SCTP syscalls too far, but I think that the right protocol needs to be picked per the address family, right? btw, I tried to move the function to sctp_syscalls.c and this required exposing soattach() and soalloc() outside. After weighting in and out decided to leave it the way it is. -- Gleb Smirnoff