From owner-freebsd-stable@FreeBSD.ORG Sun Nov 24 16:37:28 2013 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5065FD86; Sun, 24 Nov 2013 16:37:28 +0000 (UTC) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BB17A28A8; Sun, 24 Nov 2013 16:37:27 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50006814025.msg; Sun, 24 Nov 2013 16:37:24 +0000 X-Spam-Processed: mail1.multiplay.co.uk, Sun, 24 Nov 2013 16:37:24 +0000 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=10402a06b3=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: From: "Steven Hartland" To: "Andriy Gapon" , References: <20967.760.95825.310085@gargle.gargle.HOWL><51E80B30.1090004@FreeBSD.org><20968.10645.880772.30501@gargle.gargle.HOWL><520202E5.30300@FreeBSD.org><20994.55913.93606.436124@gargle.gargle.HOWL> <21111.12085.958991.356982@gargle.gargle.HOWL> <4EB902F80CE84DD2BF36C85EF4CE8EF8@multiplay.co.uk> <5284B8A5.8040604@FreeBSD.org> <52889105.7040404@FreeBSD.org> <9A58D6B0691A4C1294883AD91F9D4743@multiplay.co.uk> <5289D2FB.1010600@FreeBSD.org> <705640231AF04A91B66B0654D2531EC9@multiplay.co.uk> <5289DF99.9080101@FreeBSD.org> Subject: Re: Help with filing a [maybe] ZFS/mmap bug. Date: Sun, 24 Nov 2013 16:37:14 -0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Nov 2013 16:37:28 -0000 ----- Original Message ----- From: "Andriy Gapon" >>>> ----- Original Message ----- From: "Andriy Gapon" >>>>> - vm_page_clear_dirty(pp, off, nbytes); >>>>> + if (nbytes != 0) >>>>> + vm_page_clear_dirty(pp, off, nbytes); >>>>> } >>>>> break; >>>> >>>> Thanks Andriy, looking to test this here but 8.3 doesn't have a page_busy >>>> method in zfs_vnops.c so I'm not sure how to proceed on this? >>> >>> Does it have vm_page_clear_dirty call? >> >> Nope. >> > > Then you do not have this bug. It's possible that you might have a different > bug, though. Perhaps merge the relevant change from stable/8 and then apply the > patch?.. Backported the r248946 & 248960 then applied this fix and we've not seen any rrd corruption since :) Thanks for working on this! Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.