From owner-freebsd-current@FreeBSD.ORG  Mon Apr  2 17:17:49 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 642D91065672
	for <current@freebsd.org>; Mon,  2 Apr 2012 17:17:49 +0000 (UTC)
	(envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
	by mx1.freebsd.org (Postfix) with ESMTP id E1C4B8FC0C
	for <current@freebsd.org>; Mon,  2 Apr 2012 17:17:48 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
	by mx1.stack.nl (Postfix) with ESMTP id B9C971DD418;
	Mon,  2 Apr 2012 19:17:47 +0200 (CEST)
Received: by snail.stack.nl (Postfix, from userid 1677)
	id A0E452847A; Mon,  2 Apr 2012 19:17:47 +0200 (CEST)
Date: Mon, 2 Apr 2012 19:17:47 +0200
From: Jilles Tjoelker <jilles@stack.nl>
To: Kristof Provost <kristof@sigsegv.be>
Message-ID: <20120402171747.GA47006@stack.nl>
References: <20120401141423.GA22944@psyche>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120401141423.GA22944@psyche>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: current@freebsd.org
Subject: Re: Build error in bin/sh/jobs.c if DEBUG=2
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 17:17:49 -0000

On Sun, Apr 01, 2012 at 04:14:24PM +0200, Kristof Provost wrote:
> While chasing down an odd issue with alignment faults I activated
> debugging in bin/sh.
> bin/sh/Makefile has a commented out line (# DEBUG_FLAGS+= -g -DDEBUG=2
> -fno-inline) to do this so that's what I did.

> This fails to compile in bin/sh/jobs.c in vforkexecshell().
> The debug TRACE() tries to print variables which don't exist.

> The patch below fixes the compilation problem, but I'm unsure if it's
> printing the relevant information.

Thanks, I committed a fix. I fairly arbitrarily chose some information
to print, since I do not use -DDEBUG=2 myself.

-- 
Jilles Tjoelker