From owner-freebsd-bugs  Fri Apr 25 09:40:52 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id JAA25994
          for bugs-outgoing; Fri, 25 Apr 1997 09:40:52 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA25989
          for <bugs@freebsd.org>; Fri, 25 Apr 1997 09:40:50 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id CAA03895; Sat, 26 Apr 1997 02:36:28 +1000
Date: Sat, 26 Apr 1997 02:36:28 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199704251636.CAA03895@godzilla.zeta.org.au>
To: bde@zeta.org.au, bugs@freebsd.org, jc@netview.net
Subject: Re: owner sticky and mv
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

I wrote:

>diff -c2 cp/utils.c~ cp/utils.c
>*** cp/utils.c~	Sun Feb 23 12:34:58 1997
>--- cp/utils.c	Sun Feb 23 12:35:00 1997
>***************
>*** 160,165 ****
>  	 */
>  
>! 	if (pflag && setfile(fs, to_fd))
>! 		rval = 1;
>  	/*
>  	 * If the source was setuid or setgid, lose the bits unless the
>--- 160,165 ----
>  	 */
>  
>! 	if (pflag)
>! 		rval = setfile(fs, to_fd);
>  	/*
>  	 * If the source was setuid or setgid, lose the bits unless the

This isn't quite right - it sometimes changes rval from 1 to 0.  The
main point of it is not run the `else' clause when setfile() fails.

Bruce