From owner-dev-commits-src-all@freebsd.org Sun Jan 24 19:51:45 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8384D4D83D6; Sun, 24 Jan 2021 19:51:45 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DP3Xx3K65z4VxN; Sun, 24 Jan 2021 19:51:45 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 601DD2652F; Sun, 24 Jan 2021 19:51:45 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f46.google.com with SMTP id cu2so5264499qvb.12; Sun, 24 Jan 2021 11:51:45 -0800 (PST) X-Gm-Message-State: AOAM533ky41SNheNDSWKbcp1Y5Q2ywv/4DvKNk0dM2vCGXb07iSTKvYD eTx3sLcuT67NqEmCQqHHgLpHAiY750Ih/0ePvE8= X-Google-Smtp-Source: ABdhPJxxRnzeAhmBlZ4RI14CZVFEOkeGU7nVuxAhb3hdsCnDbtHFEtmUZk1Esh3apituvOYlsw8uUAfKxxjPp+VYttA= X-Received: by 2002:a0c:f601:: with SMTP id r1mr595118qvm.39.1611517904940; Sun, 24 Jan 2021 11:51:44 -0800 (PST) MIME-Version: 1.0 References: <202101241941.10OJfCGA013081@gitrepo.freebsd.org> <20210124194640.GA6527@belenus.iks-jena.de> In-Reply-To: <20210124194640.GA6527@belenus.iks-jena.de> From: Kyle Evans Date: Sun, 24 Jan 2021 13:51:31 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 5fe433a6e4d8 - main - netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support To: Lutz Donnerhacke Cc: Lutz Donnerhacke , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2021 19:51:45 -0000 On Sun, Jan 24, 2021 at 1:47 PM Lutz Donnerhacke wrote: > > On Sun, Jan 24, 2021 at 07:41:12PM +0000, Lutz Donnerhacke wrote: > > commit 5fe433a6e4d8cab6b64284698301afc0c55a9db2 > > Author: Neel Chauhan > > AuthorDate: 2021-01-24 19:23:39 +0000 > > Commit: Lutz Donnerhacke > > CommitDate: 2021-01-24 19:38:35 +0000 > > > > netgraph/ng_nat: Add RFC 6598/Carrier Grade NAT support > > > > This extends upon the RFC 6598 support to libalias/ipfw in r357092. > > > > Reviewed By: manpages (bcr), donner, adrian, kp > > Approved by: kp (mentor) > > MFC after: 1 month > > Differential Revision: https://reviews.freebsd.org/D23461 > > git allows us to distinguish between Author and Committer. > > I used this (after a discussion with my mentor) to attribute a foreign > submission (nc has no src bit) directly to the Autor instead of setting > "Submitted by:" (as used under subversion) > > Question: What is the prefered method to commit for an other person? > > traditional: > > Author: committer > > Commit: committer > > > > patch > > Submitted by: author > > or (as above): > > Author: author > > Commit: committer > > > > patch > > Any opinions? We switched up the recommendations[0][1] to advocate for what you've done here ~2 weeks ago -- so yes, this is good. :-) Thanks, Kyle Evans [0] https://github.com/bsdimp/freebsd-git-docs/blob/main/meta.md [1] https://github.com/bsdimp/freebsd-git-docs/blob/main/pull-request.md