From owner-svn-ports-head@FreeBSD.ORG  Thu Aug 21 10:02:42 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 86508AF8;
 Thu, 21 Aug 2014 10:02:42 +0000 (UTC)
Received: from mailrelay009.isp.belgacom.be (mailrelay009.isp.belgacom.be
 [195.238.6.176])
 by mx1.freebsd.org (Postfix) with ESMTP id A5C6F30E8;
 Thu, 21 Aug 2014 10:02:41 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AlUGAMTC9VNR8bzn/2dsb2JhbABagw3SNIMdAYEOF3eEBAEFOhwjEAsOCgklDyoeBohZAcIMF49MB4RMAQScRpULg2A7gn4BAQE
Received: from 231.188-241-81.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([81.241.188.231])
 by relay.skynet.be with ESMTP; 21 Aug 2014 12:02:34 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s7LA2Wdg003225;
 Thu, 21 Aug 2014 12:02:33 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Thu, 21 Aug 2014 12:02:32 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: John Marino <freebsd.contact@marino.st>
Subject: Re: svn commit: r365531 - in head/cad/spice: . files
Message-ID: <20140821120232.40055a67@kalimero.tijl.coosemans.org>
In-Reply-To: <53F5AE7A.7070706@marino.st>
References: <201408210603.s7L63U34069028@svn.freebsd.org>
 <53F5AE7A.7070706@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Hiroki Sato <hrs@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2014 10:02:42 -0000

On Thu, 21 Aug 2014 10:31:54 +0200 John Marino wrote:
> On 8/21/2014 08:03, Hiroki Sato wrote:
>> -	(cd ${CONFIG}/obj/bin && ${BSD_INSTALL_PROGRAM} \
>> -		spice3 nutmeg sconvert help proc2mod multidec \
>> -		${DESTDIR}${PREFIX}/bin)
>> +	cd FreeBSD/obj/bin && \
>> +		${BSD_INSTALL_PROGRAM} \
>> +		    spice3 nutmeg sconvert help proc2mod multidec \
>> +		    ${DESTDIR}${PREFIX}/bin
> 
> I am so confused.
> Half the people say we have to wrap compound commands in parenthesis and
> the other half remove them.
> 
> Does anyone have a definite answer?
> Personally I've never seen the need but I was told not having them can
> break -j multijob support.

With -j bmake runs the entire target as one script, which means cd
changes the directory for all commands that follow.  Without -j each
command runs as a separate script and cd has no effect on the next
command.  To make sure there is no difference in behaviour between the
two modes it is best to wrap cd && prog in parenthesis, such that it
always runs in its own subshell.  It is also best to use && instead of ;
because normally you don't want to run the second command if the first
one fails.