From owner-svn-src-all@freebsd.org Thu Nov 29 17:27:04 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05C3B1145596; Thu, 29 Nov 2018 17:27:04 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5E8507773E; Thu, 29 Nov 2018 17:27:03 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f45.google.com with SMTP id v10so2186117ios.13; Thu, 29 Nov 2018 09:27:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=7aUp3U77+vc6lJKDp2HbQ7AksrmgibpWVG07vDlEBtE=; b=cW41MVZY0jHFfYk9HJ1x/QeiwaJfPa+B6HoIY0egvg1WAnZtQp+bP2RB7ENsO/KP4r ds3TJeKvCUF6W5BxXji9qJvf7F76mzfYka7rrh8Ixuz/czh8zRyEOxqk/7gONihO0pYH Ssxv1nkqFJ/zGFV3THynzMveSCg+yPmP8wE3nYuxdVpn+0wLXmJHycLpYQ7BnQ/VVf54 YrOjbbOu0CF02y25Do+mfqlzteHXbVAXPG3ksWHQC2t0vuw18UXYlr0RS+YUnKADVali kj3aN3jM1+nuZfP5Aqdb7bYk7Ohyb2gXo9Xo1e4UiWWtlA7ETSm7PDo85K90psS7jJdW PIdA== X-Gm-Message-State: AA+aEWZ3kcKLpocytd9p6pjhPDTq0bbRB/dC1xqoKkjs0QUa8ElpX6DK VHUsrjhZcJhITQr+ebYef2eNdTu1 X-Google-Smtp-Source: AFSGD/X1s3gN7yLw43Iug2bzsKNhr8gJ+SvOwdnSn1mpR3tC9mag7l+xE034IiY9c40p1Yt99RKDmw== X-Received: by 2002:a6b:c815:: with SMTP id y21mr1844728iof.98.1543512416751; Thu, 29 Nov 2018 09:26:56 -0800 (PST) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com. [209.85.166.41]) by smtp.gmail.com with ESMTPSA id c25sm952955ioa.86.2018.11.29.09.26.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 09:26:56 -0800 (PST) Received: by mail-io1-f41.google.com with SMTP id g8so2196082iop.10; Thu, 29 Nov 2018 09:26:56 -0800 (PST) X-Received: by 2002:a5d:94cc:: with SMTP id y12mr1844387ior.233.1543512415978; Thu, 29 Nov 2018 09:26:55 -0800 (PST) MIME-Version: 1.0 References: <201811291421.wATELQbx059318@repo.freebsd.org> In-Reply-To: <201811291421.wATELQbx059318@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Thu, 29 Nov 2018 09:26:45 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r341232 - in head/usr.bin: . trim To: eugen@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 5E8507773E X-Spamd-Result: default: False [-5.82 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-2.83)[ip: (-9.24), ipnet: 209.85.128.0/17(-3.47), asn: 15169(-1.32), country: US(-0.09)]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.985,0]; RCVD_IN_DNSWL_NONE(0.00)[45.166.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 17:27:04 -0000 Hi Eugene, On Thu, Nov 29, 2018 at 6:22 AM Eugene Grosbein wrote: > > Author: eugen > Date: Thu Nov 29 14:21:26 2018 > New Revision: 341232 > URL: https://svnweb.freebsd.org/changeset/base/341232 > > Log: > Add new small tool trim(1) to delete contents for blocks on flash > based storage devices that use wear-leveling algorithms. > > Reviewed by: hackers@ > MFC after: 1 month As much as I also want a tool like this, please back out the commit for now. It was never code reviewed; that's what the "Reviewed by:" annotation means. It was *discussed*, but not universally approved, on hackers@. I think this should probably be backed out and at least given basic code review first. I volunteer to do that in a timely fashion myself; there is at least one glaring issue in the tool just scanning the code. It should have some basic review before anything like "MFC after" is suggested and we commit to basically adding a userspace API. At least Warner, and possibly others, should be on the review as well. Thanks, Conrad