From owner-freebsd-stable@freebsd.org Sun Jun 2 14:03:31 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F377215B6838 for ; Sun, 2 Jun 2019 14:03:30 +0000 (UTC) (envelope-from stefan.hegnauer@gmx.ch) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5DA136A823; Sun, 2 Jun 2019 14:03:29 +0000 (UTC) (envelope-from stefan.hegnauer@gmx.ch) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1559484198; bh=SDdss4Mwf00heY7D1JCewIJfqtODNmP15o56y4e2Hak=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KJB4pmfy1uVBJq3H1ssvKAklZXPYBLb12mJyNgp6AqY1MV4xCfpQm1PSWULVudH5j Wk1+o4NicH1CpSdgK4dlSdKUbDEUSNfnJHTeukLpWk8q2DDPKZ1Wj/ui7rKUQco96B mF+WZLwEiqx+L3qNrZVv8UGPDIfXMXngHAFu/7IE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.20.50] ([84.226.167.60]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MJSQ7-1hYoer1Aap-0036XS; Sun, 02 Jun 2019 16:03:18 +0200 Subject: Re: ps -J0 broken? To: Kyle Evans , Konstantin Belousov Cc: FreeBSD-STABLE Mailing List , FreeBSD Release Engineering Team References: <3e81cb06-853b-c682-5dd2-a40191ae9a72@gmx.ch> <20190602130529.GF75280@kib.kiev.ua> From: Stefan Hegnauer Openpgp: preference=signencrypt Message-ID: Date: Sun, 2 Jun 2019 16:03:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Provags-ID: V03:K1:hdoBQXqudqpAH59KC/SkI5qS8nLZLInXAUVSTPmKYRQyvM/QHpG +BXyHprA6Xx3Pi/AGBvBDxXn2LPPGNBMnepaIaGAwWy6OZZQoRt62rEQTf4DDk8Iv8xC7bz vPYZ3D3+4V+6SZwSst13bXk159wIrRf6jXD+80IHAC0+RYQSob5iznr8mRG67y6rC/uyBhC 8fOESnjZ4XU525v4DDtaQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5FWlfShkvtI=:hRIWZAvG7rMyO/+29m80f9 RJo2z4vvrdobXs4VkHBlzYjc2IKtBJgd/oXNb9dDZs/Qo7Zm12q7US94QQLhsDgkE2XNXsaTq KytQ8Fbdlz3FcjxYHY1BBYZMSfAIIb5edEmg0gkOKl8w0L+3rVY24gdZ4Y27qLx3IqG4WqcoA QUueuMDc81Gnp1QwqLKcMUTTEn76DOxyE6p1HPwZy3Bnbw5gUHtk6vCF5xdGPIDKCO9RGw0hO ENJsCCzioyASW5MiD+Y4hAUzNW6z/6ZEjf7pi3RMvudACHTW0uNN06mYiO/wDCxS4yqTvnAQS p+9Kvp8FraICbvUPB79ah++rtoZqczRIO6fpKSD2zrT7jeiq73BhmLzNzy8kybrfXPnMccfxN jsh4vh5KgjXJtu6NvemcRZ+wbZkZk+mgADX6MSPwUA+nW0ZiyzwyF+tSoVX1c7XWwLN+a3UyZ d4XvKKvjlEw4+gAgRd2yoka//XZnYA8fKhL1kg/n1kU17H0bDVxuA8ayT5TsT/YM0S5eBIzO7 DoA28KlpWZXmdYTlyJ6Q3PmMv98fBbQSznzaCTB6DnqjiLCmGVtqZ2aeirQ5Lx2ww8ZhF8X1n umqtu6PSe/K0325YEV92fKnPTsrNW2negn2LAdVUt246CGFGcGZA9/aRXCSGtuc4YxfIMp7K/ UY8sCqtUB5TXi9XvoxCHv+Xx5oUtoE4WmrKJ4YpQ0lKv3DFxU7gGsglIX2dWG8Y60GPM/5fMn 4U4ERpk9MWPjuNOoOCLfq+vDp2dzUopu3LcLEXu71czwM/UMDF01LpqFUZi4ZqUDYlRZrX3Ho zN1hXQu8myQlCcQRunJEg4xr5marJPefw42IEyG1+aabx8kBnMx81c+Dp8/rvMViV2rT5eSDj +K5byfc6KTRFwV2ipLOKjPVwfcP/SgztCFjbo8Uh53FFb57RdLmA+Al72gqvx1z6sB64ZeoE2 Ti5E6uu+nQR2JQwFxFxF3WG4Njv6prI6UaR8VHEWrOoo00NcDGAWn X-Rspamd-Queue-Id: 5DA136A823 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=KJB4pmfy; spf=pass (mx1.freebsd.org: domain of stefan.hegnauer@gmx.ch designates 212.227.15.19 as permitted sender) smtp.mailfrom=stefan.hegnauer@gmx.ch X-Spamd-Result: default: False [-3.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:212.227.15.0/25]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gmx.ch]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; MX_GOOD(-0.01)[cached: mx00.emig.gmx.net]; RCVD_IN_DNSWL_NONE(0.00)[19.15.227.212.list.dnswl.org : 127.0.3.0]; NEURAL_HAM_SHORT(-0.77)[-0.767,0]; IP_SCORE(-0.82)[ip: (-5.23), ipnet: 212.227.0.0/16(-1.45), asn: 8560(2.57), country: DE(-0.00)]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 14:03:31 -0000 On 02.06.2019 15:51, Kyle Evans wrote: > On Sun, Jun 2, 2019 at 8:05 AM Konstantin Belousov wrote: >> On Sun, Jun 02, 2019 at 02:30:49PM +0200, Stefan Hegnauer wrote: >>> Hi, >>> >>> after a recent full update to 12.0-STABLE r348382 it seems that '/bin/ps >>> -J 0' is broken: 'ps: Invalid jail id: 0'. >>> It did work on stable for the last couple years prior to this update >>> (last update without this error was about 5 weeks ago), and should still >>> work according to ps(1): >>> -J Display information about processes which match the specified >>> jail IDs. This may be either the jid or name of the jail. >>> **Use** >>> ** -J 0 to display only host processes*.* This flag implies >>> -x by >>> default. >>> >>> My system runs several jails with JID's currently in the range 80-100. >>> The source code of ps did not change for the last 7 month as far as I >>> can tell. A fresh 'make clean & make & make install' of just ps did not >>> help either, which was not really surprising to me. >>> Any pointers where to look further? >> Is your libjail up to date ? Do you have r348297 ? > kern_jail_get refuses to do lookups for jid=0, presumably because > prison 0 is special. I'll commit quick fix- libjail should go back to > just return (jid) if jid == 0, because this will always exist. It's a > trivial patch, I intend to request permission for immediate MFC to > both stable/1{1,2} from re@ because it restores previous working > behavior for this. Thanks. I will follow up as soon as the patch is in stable/12 and I had a chance to test it.