From owner-svn-src-all@freebsd.org Sat Sep 14 15:15:02 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 93248F7733 for ; Sat, 14 Sep 2019 15:15:02 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46VwzV1Fwgz45GR for ; Sat, 14 Sep 2019 15:15:01 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1568474100; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=hp4H6aDX0pq3qawk0PYDOtfkwl1rI28jhi5hCKKyR1Wx90gshT0/16WLbhyaBnnmd+br/IW4tF/MK rbtH4KENEqlAZNaqlBnbZV4f5D1ALz9e8HK4D8djF0CKY6k9uXg1I5d3wWwJm+fzsZ0DaAH8HpM0WM KiSgJzMbNpLreJ9hstp7d77mnJA90quhJ+arAM7dY1cCyb1HFkVxHCI+louZkL1xLNpgKYcjwBAviX LosrUrox4VprY2xNDvkmQevDHKIGGz4RFkEHGoUDf3iz3wyA2XL6nVOZJTfikxyyHarRhNaw1azcSU 4EG4Tu8Lq+XUg2Vr/hpWs0tEA6YKR5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=Zb6fyPxGBOwrj+9ODsjNByFB/BK1I138Qe8baNMh95E=; b=T7v6iQjg8j1HLbiTAc1Suxlja4ovcD1DX9F4I8UJM1k+5OPS5Nx69rkYuuxfBGLtLONNXAM/tWR9K 8vVXTaScpavhC9ehEr92aa1FPRsrin0bFMx9lSvhq568zuG+vb9/Rl+v6HS9kWrg7Qn5op/B2L5WpE XqqN7EM3kHANtPHkQNWtjERTlFGe4ZaCS4/HbZBqykGNBbTQMGPrRoR1Y3U2jw4VxJJegfZ0tOmPfR 4+Tv/LYjbwmd6KZNpMqlLO/GvPSmvKCEWbtrrSletieMKNFADiscs6Ukh+zgIjcKdZuzZC/JinvOqO dHtF6l6i69DYcmuwj7DNTojivMMa0pQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=Zb6fyPxGBOwrj+9ODsjNByFB/BK1I138Qe8baNMh95E=; b=s7l0d8h8HqcqPt++bjXLqNufUV7j8W0mdErLisd8wgGabqnp0JfuueIUxZv8O2+inO5x4kHVWalQ1 ZuaFwL1U5G2CRNj4A4d0kbH7luYQBtHRvC+YaYlZy5eBbnRvHU/xXXY8N1mZFZZDsVsWecF8MEotI+ EC8hZpAvoqjfmaIYFhYNXlcVxd/PyOvQLUn8iO2jiyGgZj/24ipy2K/5LCtCRQjx8tvVqzzRYYn66e ZSBdhbFsN6DQFqhkMULnjU9uJoQjPveI1yjh3if84L3AXhEhdLlFanGgxhP1puFFtTipbBC47x4pUc 93tKHKzUuppkkt2J4+/3HoAQJKSSkNA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 692ad101-d702-11e9-b67d-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 692ad101-d702-11e9-b67d-cdd75d6ce7a8; Sat, 14 Sep 2019 15:14:59 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x8EFEub9086559; Sat, 14 Sep 2019 09:14:56 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1f18e7e147790aa280a4d35f93bf619313745200.camel@freebsd.org> Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline From: Ian Lepore To: Warner Losh , Peter Jeremy Cc: Baptiste Daroussin , Charlie Li , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 14 Sep 2019 09:14:56 -0600 In-Reply-To: References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> <20190914041041.GA97181@server.rulingia.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46VwzV1Fwgz45GR X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.00 / 15.00]; TAGGED_RCPT(0.00)[freebsd]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 15:15:02 -0000 On Fri, 2019-09-13 at 22:25 -0600, Warner Losh wrote: > On Fri, Sep 13, 2019, 10:11 PM Peter Jeremy > wrote: > > > On 2019-Sep-13 16:33:15 -0400, Charlie Li > > wrote: > > > Baptiste Daroussin wrote: > > > > Author: bapt > > > > Date: Fri Sep 13 06:50:02 2019 > > > > New Revision: 352275 > > > > URL: https://svnweb.freebsd.org/changeset/base/352275 > > > > > > > > Log: > > > > Update libedit to a snapshot from 2019-09-10 > > > > Reviewed by: Yuichiro Naito > > > > MFC after: 3 weeks > > > > Differential Revision: https://reviews.freebsd.org/D21584 > > > > > > > > > > I posted in phab but repeating here, this breaks the build on (at > > > least) > > > aarch64: > > > > It breaks the build on arm and arm64 only. > > > > wint_t is int on all platforms: > > sys/sys/_types.h: > > typedef int __ct_rune_t; /* arg type for ctype funcs > > */ > > typedef __ct_rune_t __wint_t; /* wint_t (see above) */ > > > > but wchar_t varies between unsigned and signed: > > $ grep '__wchar_t' sys/*/include/_types.h > > sys/arm/include/_types.h:typedef unsigned int ___wchar_t; > > sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; > > sys/mips/include/_types.h:typedef int ___wchar_t; > > sys/powerpc/include/_types.h:typedef int ___wchar_t; > > sys/riscv/include/_types.h:typedef int ___wchar_t; > > sys/sparc64/include/_types.h:typedef int ___wchar_t; > > sys/x86/include/_types.h:typedef int ___wchar_t; > > > > Looking back into history, it looks like the "unsigned" is part > > of the ARM EABI. > > > > We should confirm that. It is definitely part of the OABI stuff, but EABI > was supposed to fix differences like this... > The char type is unsigned by default on arm (it's part of eabi), and also on powerpc and riscv. -- Ian