From owner-cvs-all@FreeBSD.ORG Wed Mar 2 16:00:12 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A05216A4CE; Wed, 2 Mar 2005 16:00:12 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 003D643D49; Wed, 2 Mar 2005 16:00:12 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.1/8.13.1) with ESMTP id j22G26eR007294; Wed, 2 Mar 2005 09:02:06 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <4225E285.5000605@samsco.org> Date: Wed, 02 Mar 2005 08:57:57 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050218 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <200503021556.j22FugDk081853@repoman.freebsd.org> In-Reply-To: <200503021556.j22FugDk081853@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/esp esp_sbus.c ncr53c9x.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2005 16:00:12 -0000 Scott Long wrote: > scottl 2005-03-02 15:56:42 UTC > > FreeBSD src repository > > Modified files: > sys/dev/esp esp_sbus.c ncr53c9x.c > Log: > The existing locking in the esp driver appears to be fairly adequate, so > set the interrupt handler to be INTR_MPSAFE now that xpt_done() can be > called without Giant. Giant is still on the top half of the driver and > the timeout handlers. > > Revision Changes Path > 1.9 +1 -1 src/sys/dev/esp/esp_sbus.c > 1.8 +0 -2 src/sys/dev/esp/ncr53c9x.c My Ultra2 now has no [GIANT-LOCKED] messages at all during boot and seems to run without any problems. I haven't done any performance measurements yet, and enabling mpsafevfs will probably negate most improvements that this might have given, but it's a start. David O'brien: THIS IS NOT A FREEBSD 5.4 CANDIDATE. It's a shame that I'll need to postfix all of my commits from now on with this message. Scott