From owner-cvs-all@FreeBSD.ORG  Sun Oct 31 04:40:38 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5D4CD16A4CF; Sun, 31 Oct 2004 04:40:38 +0000 (GMT)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8829043D1D; Sun, 31 Oct 2004 04:40:37 +0000 (GMT)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 9DC21653F8; Sun, 31 Oct 2004 04:40:35 +0000 (GMT)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 37708-04; Sun, 31 Oct 2004 04:40:35 +0000 (GMT)
Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id B791B653DF; Sun, 31 Oct 2004 04:40:34 +0000 (GMT)
Received: by empiric.dek.spc.org (Postfix, from userid 1001)
	id AE57A6247; Sat, 30 Oct 2004 21:40:21 -0700 (PDT)
Date: Sat, 30 Oct 2004 21:40:21 -0700
From: Bruce M Simpson <bms@spc.org>
To: "Justin T. Gibbs" <gibbs@scsiguy.com>
Message-ID: <20041031044021.GA2123@empiric.icir.org>
Mail-Followup-To: "Justin T. Gibbs" <gibbs@scsiguy.com>,
	Matthew Jacob <mjacob44@yahoo.com>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <20041031035037.59607.qmail@web21422.mail.yahoo.com>
	<E024D6F9B48B27EB9B2BF6CE@caspian.scsiguy.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E024D6F9B48B27EB9B2BF6CE@caspian.scsiguy.com>
cc: Matthew Jacob <mjacob44@yahoo.com>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_vr.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Oct 2004 04:40:38 -0000

On Sat, Oct 30, 2004 at 10:35:58PM -0700, Justin T. Gibbs wrote:
> > Shouldn't an API for adding or removing ISR's be responsible for
> > handling just such a race condition?
> 
> bus_teardown_intr() already has these semantics, but you have
> to know to use it and that it should only be called without
> locks held since it may sleep waiting for another CPU to
> leave your interrupt handler.

Unfortunately I don't have a vr(4) card to test the changes with, and
it looks like the copy of if_vr.c in my local tree uses bus_teardown_intr()
correctly; these changes will have to be tested and committed after 5.3R.

BMS