From owner-cvs-all Mon Dec 30 5:12:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5651337B401; Mon, 30 Dec 2002 05:12:56 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F17543EA9; Mon, 30 Dec 2002 05:12:55 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id AAA12528; Tue, 31 Dec 2002 00:12:52 +1100 Date: Tue, 31 Dec 2002 00:14:52 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Maxime Henrion Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/pci if_xl.c In-Reply-To: <200212301246.gBUCk8VW075195@repoman.freebsd.org> Message-ID: <20021230235804.I46568-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 30 Dec 2002, Maxime Henrion wrote: > mux 2002/12/30 04:46:08 PST > > Modified files: > sys/pci if_xl.c > Log: > Leave only one of the two $FreeBSD$ tag, and use __FBSDID(). > > Revision Changes Path > 1.114 +3 -6 src/sys/pci/if_xl.c This removes the wrong tag IMO. Id strings are not normally used in the kernel. The places that do use them mostly have duplicate $FreeBSD$'s. The main places are netatm and wpaul's network drivers. if_xl.c was one of the latter. In netatm files, one of the tags should be the vendor tag and the other should be the FreeBSD tag. In the network drivers, there should be only one tag. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message