From owner-svn-src-head@FreeBSD.ORG Mon Aug 30 21:13:09 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CFEA10656B2; Mon, 30 Aug 2010 21:13:09 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2B4678FC1C; Mon, 30 Aug 2010 21:13:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o7UL5gEp074786; Mon, 30 Aug 2010 15:05:42 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 30 Aug 2010 15:05:43 -0600 (MDT) Message-Id: <20100830.150543.994771096126846682.imp@bsdimp.com> To: pjd@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20100830205814.GF1871@garage.freebsd.pl> References: <201008232204.o7NM4UPA054870@svn.freebsd.org> <20100823.173600.180924398998066421.imp@bsdimp.com> <20100830205814.GF1871@garage.freebsd.pl> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, marius@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r211722 - head/cddl/lib/libzpool X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2010 21:13:09 -0000 In message: <20100830205814.GF1871@garage.freebsd.pl> Pawel Jakub Dawidek writes: : On Mon, Aug 23, 2010 at 05:36:00PM -0600, M. Warner Losh wrote: : > In message: <201008232204.o7NM4UPA054870@svn.freebsd.org> : > Marius Strobl writes: : > : Author: marius : > : Date: Mon Aug 23 22:04:30 2010 : > : New Revision: 211722 : > : URL: http://svn.freebsd.org/changeset/base/211722 : > : : > : Log: : > : Use real atomic operations for sparc64. : > : : > : MFC after: 1 week : > : : > : Modified: : > : head/cddl/lib/libzpool/Makefile : > : : > : Modified: head/cddl/lib/libzpool/Makefile : > : ============================================================================== : > : --- head/cddl/lib/libzpool/Makefile Mon Aug 23 21:40:03 2010 (r211721) : > : +++ head/cddl/lib/libzpool/Makefile Mon Aug 23 22:04:30 2010 (r211722) : > : @@ -11,7 +11,7 @@ : > : # LIST_SRCS : > : .PATH: ${.CURDIR}/../../../sys/cddl/contrib/opensolaris/uts/common/os : > : # ATOMIC_SRCS : > : -.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "ia64" || ${MACHINE_ARCH} == "powerpc64" : > : +.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "ia64" || ${MACHINE_ARCH} == "sparc64" || ${MACHINE_ARCH} == "powerpc64" : > : .PATH: ${.CURDIR}/../../../sys/cddl/contrib/opensolaris/common/atomic/${MACHINE_ARCH} : > : ATOMIC_SRCS= opensolaris_atomic.S : > : .else : > : > I find it disturbing that we have 3 or 4 copies of this code in our : > Makefiles... : : Then you will like @183089 :) Yea, I have something very similar in my TBEMD branch... :) Warner