From nobody Sat May 16 13:48:03 2026 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gHlkr71XFz6cQWp for ; Sat, 16 May 2026 13:48:04 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gHlkr6PWnz3Y4x; Sat, 16 May 2026 13:48:04 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778939284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0fUfzYsTWj4Wt+Y9SFPs4DZ93OAty04nr85icIU1LL8=; b=uC6BDZfjf2NO14B1NV8ka3biq0GxXYDjHjZbvQZjmwjmCS+cCBPlHzEyJDZtkr5r6KPZgi LxfoJQiTP2KO3J48vbtuHekcC1HafLqgQmXsBU98Lq6bx4JG421rlJs0zAvJHFVj+PGCyA 2HrAln1L5saOn4v80ZmuqXio4KkrHve3INtBWxcwU2ldQuFvcH8wk1TEBi1es7wjovlulS SABFmBRqItYazirmkXmc4FKq9Psj3bqQaLRtHznMfdfzEsE5x9/Mr9SD8AgeldFbgLvWRG kIIR3EFxo8DGSx1uBoGVlmAiXsqmgOJ63hrxMyVompi+LTLJGZVPigIXyb72XA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1778939284; a=rsa-sha256; cv=none; b=sOMz86EQfSR8w/xWie3Xd+X2ke+iiDeUNSgiAzJGgdL+pQ0TNoeCcDZ26MjAgGtlWMtyp5 +e7YuEZ5noQRYnhk6daHvO9i0B6oN81CcmBqgtUS8ltNA2pImEvJQCqpRP3wuFxKN6mQ5B XJ0hSYc4PS8Nrc0vreVrSYZWoVCxnjfmqbuHayUhtaPifh1hD0cv4uPx/azlNxTw5gSNzp PjY3tZBMspalC0hcElIKTb7OMH8wM5CdBiDAHq3Y3MM9Njh+6/bZte8vVmNt5KdQejAgSX 3wUfxvDnm8Ro3mGnwG9+C642m0Vl6+x7Io6x4Lv0luMuwuUGy4GTS7UPYRzHEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1778939284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0fUfzYsTWj4Wt+Y9SFPs4DZ93OAty04nr85icIU1LL8=; b=D5utnB9+06oT8qhvKt/i1S1871UmQSO+/ZqwodIQw/mIX7YL8+nNkxNPNJ5sWpdymOV9wR BL2bFY1T3DRSTV/CbjJLWFBGFM7uL/1/cUI99EU3WEMO+mTcy3odGdpQy2PZvyydsTbU8U CZKV3LfHberrVPVDtg4q0nxsc4d9uUk5B0jfs5lc0vGDzdWK1jU3poYW5Tb7bKsCep4dXU wlBba/quddsRMT1pc1vpKB0nltUD8EoCVJODFYb2fkeBfUIWFXVdFIFqJ0byMDlalF7tfn MDROprp+T73Qr8+f8bwoofua7wFtnm4n3HwK7OwOOdivf5MIUhI7UpikD3BUeQ== Received: from ltc.des.dev (2a01cb0585070b00922e16fffef1acef.ipv6.abo.wanadoo.fr [IPv6:2a01:cb05:8507:b00:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gHlkr4vTkz12xY; Sat, 16 May 2026 13:48:04 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id B7DFEA9C6B; Sat, 16 May 2026 15:48:03 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Konstantin Belousov Cc: current@freebsd.org Subject: Re: rms_rlock with non-sleepable locks held In-Reply-To: (Konstantin Belousov's message of "Sat, 16 May 2026 13:08:39 +0300") References: <86lddjelen.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Sat, 16 May 2026 15:48:03 +0200 Message-ID: <865x4nea98.fsf@ltc.des.dev> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Konstantin Belousov writes:> diff --git a/sys/kern/vf= s_subr.c b/sys/kern/vfs_subr.c > index b3a6e8ce2e02..d19776940bc3 100644 > --- a/sys/kern/vfs_subr.c > +++ b/sys/kern/vfs_subr.c > @@ -6509,7 +6509,7 @@ vop_read_post(void *ap, int rc) > struct vop_read_args *a =3D ap; >=20=20 > if (!rc) { > - VFS_KNOTE_LOCKED(a->a_vp, NOTE_READ); > + VN_KNOTE_LOCKED(a->a_vp, NOTE_READ); Did you mean to use VN_KNOTE_UNLOCKED() here... > INOTIFY(a->a_vp, IN_ACCESS); > } > } > @@ -6520,7 +6520,7 @@ vop_read_pgcache_post(void *ap, int rc) > struct vop_read_pgcache_args *a =3D ap; >=20=20 > if (rc =3D=3D 0) { > - VFS_KNOTE_LOCKED(a->a_vp, NOTE_READ); > + VN_KNOTE_UNLOCKED(a->a_vp, NOTE_READ); ...like you do here? > INOTIFY(a->a_vp, IN_ACCESS); > } > } > DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org