From owner-svn-src-all@freebsd.org Mon Jun 25 11:43:19 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A0801009ABB; Mon, 25 Jun 2018 11:43:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D5C7878DFC; Mon, 25 Jun 2018 11:43:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTP id w5PBh8O3093614; Mon, 25 Jun 2018 14:43:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w5PBh8O3093614 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w5PBh8jW093613; Mon, 25 Jun 2018 14:43:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 25 Jun 2018 14:43:08 +0300 From: Konstantin Belousov To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335632 - in head/sys: dev/vt/hw/vga x86/include x86/isa x86/x86 Message-ID: <20180625114308.GD2430@kib.kiev.ua> References: <201806251101.w5PB1CH0008674@repo.freebsd.org> <197a8c03-b27f-0ebb-7ce6-39a7392d5192@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <197a8c03-b27f-0ebb-7ce6-39a7392d5192@FreeBSD.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 11:43:19 -0000 On Mon, Jun 25, 2018 at 02:22:30PM +0300, Andriy Gapon wrote: > On 25/06/2018 14:01, Konstantin Belousov wrote: > > Modified: head/sys/x86/x86/cpu_machdep.c > > ============================================================================== > > --- head/sys/x86/x86/cpu_machdep.c Mon Jun 25 10:52:41 2018 (r335631) > > +++ head/sys/x86/x86/cpu_machdep.c Mon Jun 25 11:01:12 2018 (r335632) > > Maybe acpi_machdep.c or some other file under x86/acpica would be better... I do not want to create a file for single 10-line function. I considered it and decided that this is silly. If you have plans for the other content, then sys/x86/acpi/acpi_machdep.c or similar may be a good idea indeed.