From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Mar 23 15:04:38 2006 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AB0316A420; Thu, 23 Mar 2006 15:04:38 +0000 (UTC) (envelope-from itetcu@people.tecnik93.com) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18FBE43D5E; Thu, 23 Mar 2006 15:04:34 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id 777F91773F; Thu, 23 Mar 2006 17:04:17 +0200 (EET) Date: Thu, 23 Mar 2006 17:04:17 +0200 From: Ion-Mihai Tetcu To: "Frank W. Josellis" Message-ID: <20060323170417.7dfeaa48@it.buh.tecnik93.com> In-Reply-To: <20060323133612.J6641@pollux.senax.net> References: <200603222154.k2MLsUZJ038943@freefall.freebsd.org> <20060323133612.J6641@pollux.senax.net> X-Mailer: Sylpheed-Claws 2.0.0 (GTK+ 2.8.16; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Thierry Thomas , freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/93972: Update port: astro/xmoontool to 3.0.3 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2006 15:04:38 -0000 On Thu, 23 Mar 2006 14:29:12 +0100 (CET) "Frank W. Josellis" wrote: > > > On Wed, 22 Mar 2006, Thierry Thomas wrote: > > > This port does not respect CFLAGS, CC nor PREFIX; what about the > > following patch? (Since I'm there, reorganize Makefile) > > You are right, but please note that patching PREFIX into the tarball's > Makefile has no effect on the port. It's only the install target that > involves PREFIX. This isn't used, as the port's installation is solely > carried out by do-install in the port's Makefile. > > Well, I considered the tarball's CC and CFLAGS settings as acceptable for > the port and couldn't imagine a situation where it is essential to have > them overwritten. But I suppose you are more acquainted with the formal > requirements on FreeBSD ports, so I better leave it to you. If you feel > it's an advantage which justifies the patch, I won't protest. > > I wasn't yet aware that USE_REINPLACE meanwhile became obsolete, but I'll > know in future. Run a `portlint -A` in the port directory will help you with a lot of interesting things ;) -- IOnut - Unregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" Ferengi Rule of Acquisition #144: There's nothing wrong with charity... as long as it winds up in your -- ST: Legends of the Ferengi