From owner-svn-src-all@freebsd.org Sun Jul 28 16:14:33 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E6B6AEC94; Sun, 28 Jul 2019 16:14:33 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B04366C55F; Sun, 28 Jul 2019 16:14:32 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f193.google.com with SMTP id x25so56183617ljh.2; Sun, 28 Jul 2019 09:14:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z7zft41QOnIocm4Kx6vXi2U06rgxr1GSRQjkIvjsv2s=; b=TNXQb6vAHmQPq271S7ur787nIuQzFC+cdpliqf1E4nIbUVHONXLXSLDFbwoJBaNLLT QVYQcC01se3xet8CudF5Ore+UExfvrJyKotX3c9shy4aXQ4agi8ahf7OP9TX2gMFKI8t wCiL+Lh6UPd3uV3XMuMGuf36ww1AGWLQlqGnIxFSGE2u1BqNSqJvn4T0xaLYWPP2+6Ic o/sZw6WSPKaaeJXKUs2VozXpVUZ1GHEHhPZ4k6BrSq5uSdmxDagjtJxlWIg6/rjIA7gH wnTc2143P5YwkMgjx31YgcBu7hq+Up/yiRo/Dytuf21O/2Hua4czocf+6O3h4NPyLqeZ gDFQ== X-Gm-Message-State: APjAAAV0vv1LGUIbqRXHrVWthkwQk+P+TtPpP5+faO8oir2d5sIDR2zN wgaZWyH075gOB9dTkw0PaWxk4W20c1U0tjFpXP9yJQ== X-Google-Smtp-Source: APXvYqzITniiEegWinPiwV9+7AnEr/jC865DMyo9DQpcUnbQmG7FF9haP9bzSwfcA6vp4sgiDaGOvsU/It5Ok3yRVsE= X-Received: by 2002:a2e:1290:: with SMTP id 16mr53077476ljs.88.1564330470749; Sun, 28 Jul 2019 09:14:30 -0700 (PDT) MIME-Version: 1.0 References: <201907281607.x6SG7SV3080649@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Sun, 28 Jul 2019 10:14:19 -0600 Message-ID: Subject: Re: svn commit: r350390 - head/sys/kern To: Niclas Zeising Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B04366C55F X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.193 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-4.16 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.959,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[193.208.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.92)[-0.916,0]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[193.208.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.27)[ip: (-0.46), ipnet: 209.85.128.0/17(-3.42), asn: 15169(-2.44), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2019 16:14:33 -0000 On Sun, Jul 28, 2019 at 10:11 AM Niclas Zeising wrote: > > On 2019-07-28 18:07, Alan Somers wrote: > > Author: asomers > > Date: Sun Jul 28 16:07:27 2019 > > New Revision: 350390 > > URL: https://svnweb.freebsd.org/changeset/base/350390 > > > > Log: > > Better comments for vlrureclaim > > > > MFC after: 2 weeks > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/sys/kern/vfs_subr.c > > > > Modified: head/sys/kern/vfs_subr.c > > ============================================================================== > > --- head/sys/kern/vfs_subr.c Sun Jul 28 15:20:47 2019 (r350389) > > +++ head/sys/kern/vfs_subr.c Sun Jul 28 16:07:27 2019 (r350390) > > @@ -947,9 +947,16 @@ vattr_null(struct vattr *vap) > > * desirable to reuse such vnodes. These conditions may cause the > > * number of vnodes to reach some minimum value regardless of what > > * you set kern.maxvnodes to. Do not set kern.maxvnodes too low. > > + * > > + * @param mp Try to reclaim vnodes from this mountpoint > > + * @param reclaim_nc_src Only reclaim directories with outgoing namecache > > + * entries if this argument is strue > > + * @param trigger Only reclaim vnodes with fewer than this many resident > > + * pages. > > + * @return The number of vnodes that were reclaimed. > > */ > > static int > > -vlrureclaim(struct mount *mp, int reclaim_nc_src, int trigger) > > +vlrureclaim(struct mount *mp, bool reclaim_nc_src, int trigger) > > { > > struct vnode *vp; > > int count, done, target; > > @@ -1238,7 +1245,8 @@ vnlru_proc(void) > > { > > struct mount *mp, *nmp; > > unsigned long onumvnodes; > > - int done, force, reclaim_nc_src, trigger, usevnodes; > > + int done, force, trigger, usevnodes; > > + bool reclaim_nc_src; > > > > EVENTHANDLER_REGISTER(shutdown_pre_sync, kproc_shutdown, vnlruproc, > > SHUTDOWN_PRI_FIRST); > > Was this change intended? It's not mentioned in the commit message. > Thanks! > Regards > -- > Niclas Yes, it was intended. Since it makes no difference at runtime, I thought of the type change as basically being documentation. That's why I didn't explicitly mention it. -Alan