Date: Thu, 21 Jan 2016 06:03:37 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r406792 - in head/editors: . the the/files Message-ID: <20160121060336.GA86366@FreeBSD.org> In-Reply-To: <201601201859.u0KIxINd074757@repo.freebsd.org> References: <201601201859.u0KIxINd074757@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 20, 2016 at 06:59:18PM +0000, Kurt Jaeger wrote: > New Revision: 406792 > URL: https://svnweb.freebsd.org/changeset/ports/406792 > > New port: editors/the > > In fact, this is a reanimation with a newer version. > [...] > > Added: > head/editors/the/ > - copied from r349686, head/editors/the/ Thanks for making a repocopy. > -PORTVERSION= 3.2 > -PORTREVISION= 1 > +PORTVERSION= 3.3.r4 > CATEGORIES= editors > -MASTER_SITES= SF/hessling-editor/hessling-editor/${PORTVERSION} > -DISTNAME= THE-${PORTVERSION} > +MASTER_SITES= http://downloads.sourceforge.net/hessling-editor/ > +DISTNAME= THE-${PORTVERSION:S/.r/RC/} PORTVERSION and DISTVERSION are mixed up here. DISTVERSION should be set to 3.3RC4, so default DISTFILE would work, and PORTVERSION would get that 3.3.r4 value automatically; consult b.p.m. around line 1286 to see how it works. > .if ${PORT_OPTIONS:MXCURSES} > CONFIGURE_ARGS+=--with-xcurses \ > --with-cursesincdir=${LOCALBASE}/include \ > --with-curseslibdir=${LOCALBASE}/lib > -BUILD_DEPENDS+= pdcurses-the>=3.2:${PORTSDIR}/devel/pdcurses-the > -LIB_DEPENDS+= XCurses.2:${PORTSDIR}/devel/pdcurses-the > +BUILD_DEPENDS+= pdcurses:${PORTSDIR}/devel/pdcurses > +LIB_DEPENDS+= libxcurses.so:${PORTSDIR}/devel/pdcurses You might want to consider using option helpers here (and below). > +pre-install: > + ${MKDIR} ${STAGEDIR}${DOCSDIR} > + ${INSTALL_DATA} ${WRKSRC}/*.html ${STAGEDIR}${DOCSDIR} > + ${INSTALL_DATA} ${WRKSRC}/the64.gif ${STAGEDIR}${DOCSDIR} > + ${INSTALL_DATA} ${WRKSRC}/the64.png ${STAGEDIR}${DOCSDIR} Bogus excessive whitespace; we don't do this type of indentation in ports. > post-install: > .if ${PORT_OPTIONS:MXCURSES} > - @${LN} -sf xthe ${PREFIX}/bin/the > + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/xthe > + ${LN} -sf xthe ${STAGEDIR}${PREFIX}/bin/the Bogus whitespace again; consider using `post-install-XCURSES-on' target. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160121060336.GA86366>