From owner-svn-src-user@FreeBSD.ORG Tue Sep 13 09:32:49 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C941106564A; Tue, 13 Sep 2011 09:32:49 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4D23E8FC08; Tue, 13 Sep 2011 09:32:49 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p8D9WndL074284; Tue, 13 Sep 2011 09:32:49 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p8D9WnSY074282; Tue, 13 Sep 2011 09:32:49 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201109130932.p8D9WnSY074282@svn.freebsd.org> From: Adrian Chadd Date: Tue, 13 Sep 2011 09:32:49 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r225527 - user/adrian/if_ath_tx/sys/dev/ath X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2011 09:32:49 -0000 Author: adrian Date: Tue Sep 13 09:32:48 2011 New Revision: 225527 URL: http://svn.freebsd.org/changeset/base/225527 Log: Remove this bit of debugging; it's no longer needed as I think I've finally found the source of the missing TX interrupts. (I'll fix that in a subsequent commit once I've verified the test actually does finally fix it.) Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Tue Sep 13 08:49:52 2011 (r225526) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Tue Sep 13 09:32:48 2011 (r225527) @@ -1342,7 +1342,6 @@ ath_handle_intr(void *arg, int npending) HAL_INT status; struct ath_hal *ah = sc->sc_ah; struct ifnet *ifp = sc->sc_ifp; - uint32_t txqs; if (sc->sc_invalid) { /* @@ -1381,20 +1380,6 @@ ath_handle_intr(void *arg, int npending) } /* - * If at this point, any of the TX interrupt status lines are - * active, we've messed up. These should only be updated in - * ath_intr(). - */ - txqs = 0xff; - ath_hal_gettxintrtxqs(ah, &txqs); - if (txqs != 0) { - device_printf(sc->sc_dev, - "%s: unserviced TXQs: txq mask=0x%.08x, int status=0x%.08x\n", - __func__, txqs, status); - /* XXX since it's been cleared, there's no way to fix it.. */ - } - - /* * If TX or RX occured, call ath_start() if the interface * can grab some packets. */