Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Sep 2011 09:32:49 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r225527 - user/adrian/if_ath_tx/sys/dev/ath
Message-ID:  <201109130932.p8D9WnSY074282@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Tue Sep 13 09:32:48 2011
New Revision: 225527
URL: http://svn.freebsd.org/changeset/base/225527

Log:
  Remove this bit of debugging; it's no longer needed as I think
  I've  finally found the source of the missing TX interrupts.
  (I'll fix that in a subsequent commit once I've verified the test
  actually does finally fix it.)

Modified:
  user/adrian/if_ath_tx/sys/dev/ath/if_ath.c

Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c
==============================================================================
--- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Tue Sep 13 08:49:52 2011	(r225526)
+++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Tue Sep 13 09:32:48 2011	(r225527)
@@ -1342,7 +1342,6 @@ ath_handle_intr(void *arg, int npending)
 	HAL_INT status;
 	struct ath_hal *ah = sc->sc_ah;
 	struct ifnet *ifp = sc->sc_ifp;
-	uint32_t txqs;
 
 	if (sc->sc_invalid) {
 		/*
@@ -1381,20 +1380,6 @@ ath_handle_intr(void *arg, int npending)
 	}
 
 	/*
-	 * If at this point, any of the TX interrupt status lines are
-	 * active, we've messed up. These should only be updated in
-	 * ath_intr().
-	 */
-	txqs = 0xff;
-	ath_hal_gettxintrtxqs(ah, &txqs);
-	if (txqs != 0) {
-		device_printf(sc->sc_dev,
-		    "%s: unserviced TXQs: txq mask=0x%.08x, int status=0x%.08x\n",
-		    __func__, txqs, status);
-		/* XXX since it's been cleared, there's no way to fix it.. */
-	}
-
-	/*
 	 * If TX or RX occured, call ath_start() if the interface
 	 * can grab some packets.
 	 */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109130932.p8D9WnSY074282>