From owner-svn-ports-head@FreeBSD.ORG  Thu Aug 21 10:10:24 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8E75CD32;
 Thu, 21 Aug 2014 10:10:24 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 63E30314C;
 Thu, 21 Aug 2014 10:10:23 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 4C29E435C7;
 Thu, 21 Aug 2014 05:10:04 -0500 (CDT)
Message-ID: <53F5C56C.4040300@marino.st>
Date: Thu, 21 Aug 2014 12:09:48 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Tijl Coosemans <tijl@FreeBSD.org>
Subject: Re: svn commit: r365531 - in head/cad/spice: . files
References: <201408210603.s7L63U34069028@svn.freebsd.org>	<53F5AE7A.7070706@marino.st>
 <20140821120232.40055a67@kalimero.tijl.coosemans.org>
In-Reply-To: <20140821120232.40055a67@kalimero.tijl.coosemans.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Hiroki Sato <hrs@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2014 10:10:24 -0000

On 8/21/2014 12:02, Tijl Coosemans wrote:
> On Thu, 21 Aug 2014 10:31:54 +0200 John Marino wrote:
>> On 8/21/2014 08:03, Hiroki Sato wrote:
>>> -	(cd ${CONFIG}/obj/bin && ${BSD_INSTALL_PROGRAM} \
>>> -		spice3 nutmeg sconvert help proc2mod multidec \
>>> -		${DESTDIR}${PREFIX}/bin)
>>> +	cd FreeBSD/obj/bin && \
>>> +		${BSD_INSTALL_PROGRAM} \
>>> +		    spice3 nutmeg sconvert help proc2mod multidec \
>>> +		    ${DESTDIR}${PREFIX}/bin
>>
>> I am so confused.
>> Half the people say we have to wrap compound commands in parenthesis and
>> the other half remove them.
>>
>> Does anyone have a definite answer?
>> Personally I've never seen the need but I was told not having them can
>> break -j multijob support.
> 
> With -j bmake runs the entire target as one script, which means cd
> changes the directory for all commands that follow.  Without -j each
> command runs as a separate script and cd has no effect on the next
> command.  To make sure there is no difference in behaviour between the
> two modes it is best to wrap cd && prog in parenthesis, such that it
> always runs in its own subshell.  It is also best to use && instead of ;
> because normally you don't want to run the second command if the first
> one fails.

Okay thanks.  So I had this right and hrs shouldn't have removed the
parenthesis.

Is this documented in PHB anywhere?  If it were simply made a rule then
there is no confusion at all.

John