From owner-cvs-src@FreeBSD.ORG Mon Mar 10 22:02:56 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2021810656D6; Mon, 10 Mar 2008 22:02:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 4F2AA8FC28; Mon, 10 Mar 2008 22:02:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 234995163-1834499 for multiple; Mon, 10 Mar 2008 18:04:26 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m2AM2T6Q090038; Mon, 10 Mar 2008 18:02:47 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Abdullah Ibn Hamad Al-Marri Date: Mon, 10 Mar 2008 17:56:23 -0400 User-Agent: KMail/1.9.7 References: <703678.84353.qm@web33702.mail.mud.yahoo.com> In-Reply-To: <703678.84353.qm@web33702.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803101756.23487.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 10 Mar 2008 18:02:47 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/6192/Mon Mar 10 10:54:00 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Rui Paulo Subject: Re: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Mar 2008 22:02:56 -0000 On Monday 10 March 2008 04:53:57 pm Abdullah Ibn Hamad Al-Marri wrote: > ----- Original Message ---- > > From: John Baldwin > > To: Abdullah Ibn Hamad Al-Marri > > Cc: cvs-src@FreeBSD.org; src-committers@FreeBSD.org; Rui Paulo > > Sent: Monday, March 10, 2008 7:56:56 PM > > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c > > > > On Saturday 08 March 2008 11:33:13 am Abdullah Ibn Hamad Al-Marri wrote: > > > ----- Original Message ---- > > > > From: Rui Paulo > > > > To: Abdullah Ibn Hamad Al-Marri > > > > Cc: src-committers@freebsd.org; cvs-src@freebsd.org; cvs-all@freebsd.org > > > > Sent: Saturday, March 8, 2008 6:38:10 PM > > > > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c > > > > > > > > On Sat, Mar 8, 2008 at 2:21 PM, Abdullah Ibn Hamad Al-Marri > > > > wrote: > > > > > > > > > > ----- Original Message ---- > > > > > > > > > > > From: Rui Paulo > > > > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; > > cvs-all@FreeBSD.org > > > > > > Sent: Saturday, March 8, 2008 5:12:35 PM > > > > > > Subject: cvs commit: src/sys/i386/cpufreq est.c > > > > > > > > > > > > rpaulo 2008-03-08 14:12:35 UTC > > > > > > > > > > > > FreeBSD src repository > > > > > > > > > > > > Modified files: (Branch: RELENG_7) > > > > > > > > > > > sys/i386/cpufreq est.c > > > > > > Log: > > > > > > MFC r1.12: > > > > > > Validate the id16 values gathered from ACPI (previously a TODO > > > > > > item). > > > > > > Style changes by me and njl. > > > > > > > > > > > > Submitted by: Takeharu KATO > > > > > > PR: 119350 > > > > > > > > > > > > Revision Changes Path > > > > > > 1.11.2.1 +59 -17 src/sys/i386/cpufreq/est.c > > > > > > > > > > Thanks, how about AMD64? > > > > > > > > This directory is shared by i386 and amd64. > > > > > > > > Regards. > > > > -- > > > > Rui Paulo > > > > > > > > > > > > > Thank you, > > > > > > Here what I got. > > > FreeBSD 7.0-STABLE #0: Sat Mar 8 16:16:54 UTC 2008 > > > arabian@MX1.WeArab.Net:/usr/obj/usr/src/sys/MX1 > > > Timecounter "i8254" frequency 1193182 Hz quality 0 > > > CPU: Intel(R) Core(TM)2 Duo CPU E6750 @ 2.66GHz (2666.62-MHz K8-class > > CPU) > > > Origin = "GenuineIntel" Id = 0x6fb Stepping = 11 > > > > > Features=0xbfebfbff > > > > > Features2=0xe3fd > > > AMD Features=0x20100800 > > > AMD Features2=0x1 > > > Cores per package: 2 > > > usable memory = 4276043776 (4077 MB) > > > avail memory = 4106977280 (3916 MB) > > > ACPI APIC Table: > > > FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs > > > cpu0 (BSP): APIC ID: 0 > > > cpu1 (AP): APIC ID: 1 > > > ioapic0 irqs 0-23 on motherboard > > > acpi0: on motherboard > > > acpi0: [ITHREAD] > > > acpi0: Power Button (fixed) > > > Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000 > > > acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0 > > > acpi_hpet0: iomem 0xfed00000-0xfed003ff on > > acpi0 > > > Timecounter "HPET" frequency 14318180 Hz quality 900 > > > cpu0: on acpi0 > > > est0: on cpu0 > > > est: CPU supports Enhanced Speedstep, but is not recognized. > > > est: cpu_vendor GenuineIntel, msr 82a082a0600082a > > > device_attach: est0 attach returned 6 > > > p4tcc0: on cpu0 > > > cpu1: on acpi0 > > > est1: on cpu1 > > > est: CPU supports Enhanced Speedstep, but is not recognized. > > > est: cpu_vendor GenuineIntel, msr 82a082a0600082a > > > device_attach: est1 attach returned 6 > > > p4tcc1: on cpu1 > > > > Try www.freebsd.org/~jhb/patches/est_msr.patch > > > > -- > > John Baldwin > > Hey John > > FreeBSD is a registered trademark of The FreeBSD Foundation. > FreeBSD 7.0-STABLE #1: Mon Mar 10 20:43:50 UTC 2008 > arabian@MX1.WeArab.Net:/usr/obj/usr/src/sys/MX1 > Timecounter "i8254" frequency 1193182 Hz quality 0 > CPU: Intel(R) Core(TM)2 Duo CPU E6750 @ 2.66GHz (2666.62-MHz K8-class CPU) > Origin = "GenuineIntel" Id = 0x6fb Stepping = 11 > Features=0xbfebfbff HTT,TM,PBE> > Features2=0xe3fd > AMD Features=0x20100800 > AMD Features2=0x1 > Cores per package: 2 > usable memory = 4276043776 (4077 MB) > avail memory = 4106977280 (3916 MB) > ACPI APIC Table: > FreeBSD/SMP: Multiprocessor System Detected: 2 CPUs > cpu0 (BSP): APIC ID: 0 > cpu1 (AP): APIC ID: 1 > ioapic0 irqs 0-23 on motherboard > acpi0: on motherboard > acpi0: [ITHREAD] > acpi0: Power Button (fixed) > Timecounter "ACPI-fast" frequency 3579545 Hz quality 1000 > acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0 > acpi_hpet0: iomem 0xfed00000-0xfed003ff on acpi0 > Timecounter "HPET" frequency 14318180 Hz quality 900 > cpu0: on acpi0 > est0: on cpu0 > est0: Guessed bus clock (high) of 333 MHz > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > est0: Guessed bus clock (low) of 333 MHz > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > est: CPU supports Enhanced Speedstep, but is not recognized. > est: cpu_vendor GenuineIntel, msr 82a082a0600082a > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > device_attach: est0 attach returned 6 > p4tcc0: on cpu0 Unless you really have a bus clock of 333 (in which case the test needs to be updated) the MSR's don't add up. You can try changing the statement that tests for 100 or 133 to accept 333 as well. -- John Baldwin