From owner-freebsd-net@freebsd.org  Sat Feb 10 19:26:38 2018
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ED48F16856
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sat, 10 Feb 2018 19:26:38 +0000 (UTC) (envelope-from mike@karels.net)
Received: from mail.karels.net (mail.karels.net [216.160.39.52])
 by mx1.freebsd.org (Postfix) with ESMTP id 344656D54E
 for <freebsd-net@freebsd.org>; Sat, 10 Feb 2018 19:26:37 +0000 (UTC)
 (envelope-from mike@karels.net)
Received: from mail.karels.net (localhost [127.0.0.1])
 by mail.karels.net (8.15.2/8.15.2) with ESMTP id w1AJQZcZ008010;
 Sat, 10 Feb 2018 13:26:36 -0600 (CST) (envelope-from mike@karels.net)
Message-Id: <201802101926.w1AJQZcZ008010@mail.karels.net>
To: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net>
cc: Ryan Stone <rysto32@gmail.com>, freebsd-net <freebsd-net@freebsd.org>
From: Mike Karels <mike@karels.net>
Reply-to: mike@karels.net
Subject: Re: Review: Fix regression that did not allow "route change" that
 didn't re-specify the gateway
In-reply-to: Your message of Sat, 10 Feb 2018 08:33:26 -0800.
 <201802101633.w1AGXRSY035991@pdx.rh.CN85.dnsmgr.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8008.1518290795.1@mail.karels.net>
Date: Sat, 10 Feb 2018 13:26:35 -0600
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Feb 2018 19:26:38 -0000

> > A change a while back (r264986) broke the ability to change a route's
> > parameters if the gateway wasn't explicitly specified again.  For

> Was the a feature by accident or design?  As the man page does not
> say that "gateway" is optional on a change command, it shows it
> as a required parameter.

I can confirm that the feature was by design, and it has been that way
for a long time.  The man page wasn't sufficiently clear about the
difference between "change" and "add" (or, for that matter, "get",
which does not require the gateway either, for obvious reasons).

I'll take a look at the review.

		Mike