From owner-svn-src-all@freebsd.org Fri Aug 26 20:20:10 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21C44B742FE for ; Fri, 26 Aug 2016 20:20:10 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x22e.google.com (mail-yw0-x22e.google.com [IPv6:2607:f8b0:4002:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC90731C for ; Fri, 26 Aug 2016 20:20:09 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x22e.google.com with SMTP id z8so55273376ywa.1 for ; Fri, 26 Aug 2016 13:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+xKuO1slArU/fL/5CW3Acgp4mFy1t5F2/AbvvRxrYoQ=; b=nrYMfDZ3/cmMrymKMIqzB9pfiCrYFIJ/Sq/6sELF45/CpDKg4qGJj3u2wh8ugenqsu +cR6F3venfDQX9Dr/xtfXV7KuWic4AnEHlQxmmjRHKMjS0pmVurwHtRTVvaMCibMLaCs La9TNqudCrorgDpXS/GCmeGy5ZLdm5BVYuaS2D4OJbMSv3B7sR8yk4d08M26+B1RaYhc tMWWp9ykpLBqx3W59yWk3+ancNCPbiPcH4kzUJQK8pRhhfj7gkH20QcjBRxaA5uRFWr+ XM5N1bjwHNb5H74KAOrA4N2H6rMycc1NQIbl0rqwoR0PS9lf53tO4yXT3rVAeu2mIxBt rnng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+xKuO1slArU/fL/5CW3Acgp4mFy1t5F2/AbvvRxrYoQ=; b=HVNimSA3en2RPm0J0zviUsqlvDx4yI6k4Ox/Aodm/OEqlBT+iBmM6Lgh9nZuwFrcWY /A3EBHSWCCgTE4KUdBs7a4eTXmkCegt0ii5wMdvGSnj70qM3exyLaFxN+Z7hWd17VyLr JTSYxAr50b50GfPzqZVlnl2dl/qRt9kXWDwRGYiTVjSYKjJUv6jT+Vtb8Vnx9eetdPc4 DjJaNrWGmXuOj0QpnGkHY+1XFxmovOw4PWrV8OOh1Cvofc99V5gV8FBu7Xl19QJOPabh CdaI5dmes8LJYGhSucPOD+wcYF3kS5d/7EjP56unDkK3RyH3X/YyWXLGQ+4Bwf+JD+e3 d0lA== X-Gm-Message-State: AE9vXwPto6FDhq7hcq5eSgZvf9/2cTbpRyLQY64IEfHKceNFYWWwqgzYrBc3jd5DgLzGbCUEwPTDTQA79Ry6Tg== X-Received: by 10.129.122.7 with SMTP id v7mr4797920ywc.219.1472242808932; Fri, 26 Aug 2016 13:20:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.201.71 with HTTP; Fri, 26 Aug 2016 13:20:08 -0700 (PDT) In-Reply-To: <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> References: <201608120703.u7C73whf007189@repo.freebsd.org> <1ce79adf-94cc-e5d3-7b8b-0914f2b07512@FreeBSD.org> <2038784.5k3koFGWFB@ralph.baldwin.cx> <7faebb9e-897a-0a7e-0ec7-c599e8658095@FreeBSD.org> From: Ed Schouten Date: Fri, 26 Aug 2016 22:20:08 +0200 Message-ID: Subject: Re: svn commit: r303988 - head/lib/libc/gen To: Bryan Drewery Cc: John Baldwin , Guido Falsi , svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Schouten Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 20:20:10 -0000 Hey, 2016-08-26 22:04 GMT+02:00 Bryan Drewery : > On 8/26/2016 12:57 PM, John Baldwin wrote: >> Alternatively, couldn't you just leave basename out of the libgen patch >> for now and only add it once you do the real symver bump for the >> different version? (That is, just use __generic() for dirname() for >> now since that is the only one that has really changed.) > > Doing this also works. > > I think it was done since the prototype did change as well which > disallows building the old xinstall directly, but in the bootstrap build > it is built with MK_WARNS=no so the error is ignored. That's good to know. I'll land this change in a couple of minutes from now, reverting any of the changes related to basename(). Guido, Bryan, thanks for testing! -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717