Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Sep 2024 13:04:52 +0000
From:      bugzilla-noreply@freebsd.org
To:        net@FreeBSD.org
Subject:   [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute)
Message-ID:  <bug-280701-7501-K1XsKFx5pi@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-280701-7501@https.bugs.freebsd.org/bugzilla/>
References:  <bug-280701-7501@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701

--- Comment #92 from commit-hook@FreeBSD.org ---
A commit in branch releng/13.3 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3Df51f7cb8997f2e43047a84e937144c2ac=
7e84587

commit f51f7cb8997f2e43047a84e937144c2ac7e84587
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2024-08-12 14:07:35 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-09-19 13:00:07 +0000

    pf: fix icmp-in-icmp state lookup

    In 534ee17e6 pf state checking for ICMP(v6) was made stricter. This cha=
nge
    failed to correctly set the pf_pdesc for ICMP-in-ICMP lookups, resultin=
g in
ICMP
    error packets potentially being dropped incorrectly.
    Specially, it copied the ICMP header into a separate variable, not into=
 the
    pf_pdesc.

    Populate the required pf_pdesc fields for the embedded ICMP packet's st=
ate
lookup.

    Approved by:    so
    Security:       FreeBSD-EN-24:16.pf
    PR:             280701
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit 2da98eef1f352c496ffd458b4c68ddee972bb903)
    (cherry picked from commit 0d8d4cc3ea47f1ee61d749b22b135eb73c7d33cd)

 sys/netpfil/pf/pf.c | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280701-7501-K1XsKFx5pi>