From owner-svn-ports-head@freebsd.org Wed Jan 4 19:13:07 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0468CC9F651 for ; Wed, 4 Jan 2017 19:13:07 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB1D11BAD for ; Wed, 4 Jan 2017 19:13:06 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-oi0-x22e.google.com with SMTP id v84so553631919oie.3 for ; Wed, 04 Jan 2017 11:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=hlGUBbbishKwV7jLvZdD3RbVt1C7FSO9vEvy5GSIDJ8=; b=leU13Wc0p2yCMlAnyQAe51kFQvnpqE+W6zQZkChz2X/zgSgGKUU/lky/wris7nsiAe a1uXeVWm9BHkhyb5F+x1zs6FfQ91Rc4GDnTAKWKsJ43vnUf2pTElFSIYFCmKeA9oR5t3 8VP+4YgBxsey3SSmBALuXn4qq96s0DQCkVFUuDn4/HabbjniFULS5KvstB5c7wsPNzNr Qia50mkxObj0v/SYNX7lIvr+qx2zdbxWQhW/oOl/vE22eqYFxXG0rRmjwj634cEhwt4Q o257bKhQJtu0Z2nyWMaP009IFF9WD/kZlL/L1NglRQs5V/8Leglr6yPP8c7IbNCIM8wP vgeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=hlGUBbbishKwV7jLvZdD3RbVt1C7FSO9vEvy5GSIDJ8=; b=RI6iUOnREXHnFKWSR6/ekA5o0ar4/rbJRMCNHS+eA0Bd3nmJCljM8JFEsxXmXmQQaS li/aC1e31HInWrRQ+DzMUDyqHhw7Eyau4wXNmSdeELWHggY/1mDNkpwtx7NfaNSooaKa VHNDj75qcgWByypPgr9RS7WUdViwCS6TwmI2SGc1obTtqK7HDyjChbGlH0k04IOByDPG vybqnjdRAcZ0q9OgcRkyPUOaFZhCThv3YZe3qF1RBR6lMfAex6kmhrxkT/WXCUG6/ew3 HMZJ2R67P4DY48rFtQfwI0bjuFofBEOIvOI+4epSY6Cl5KXRZYo99SHEl4PJR0q0MJ5O +QJw== X-Gm-Message-State: AIkVDXJGQTMIruozFfOerMjWOlc0FZHbvK6XYroubr1G+AA2rDHV283mpVi4yQY0fOQ1uO+L2WvqhYo7/ii4rg== X-Received: by 10.157.12.70 with SMTP id 64mr165515otr.99.1483557186144; Wed, 04 Jan 2017 11:13:06 -0800 (PST) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.157.12.134 with HTTP; Wed, 4 Jan 2017 11:12:25 -0800 (PST) In-Reply-To: References: <201701010417.v014HjI0080871@repo.freebsd.org> <20170103111542.37681315A@freefall.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Thu, 5 Jan 2017 03:12:25 +0800 X-Google-Sender-Auth: Rc4FvsTjwJ76p-tKryGMlWLb4gA Message-ID: Subject: Re: svn commit: r430238 - head/databases/rocksdb To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 19:13:07 -0000 On Thu, Jan 5, 2017 at 3:02 AM, Sunpoet Po-Chuan Hsieh wrote: > On Tue, Jan 3, 2017 at 7:15 PM, Jan Beich wrote: > >> Sunpoet Po-Chuan Hsieh writes: >> >> > --- head/databases/rocksdb/Makefile Sun Jan 1 03:57:43 2017 >> (r430237) >> > +++ head/databases/rocksdb/Makefile Sun Jan 1 04:17:45 2017 >> (r430238) >> > @@ -50,10 +50,6 @@ ZSTD_LIB_DEPENDS= libzstd.so:archivers/z >> > >> > .include >> > >> > -.if ${OSVERSION} <= 1000000 >> > -CFLAGS+= -D_GLIBCXX_USE_C99 >> > -.endif >> > - >> >> This may be premature. The underlying issue is documented in bug 193528 >> and has only been fixed in lang/gcc6 but not in lang/gcc or lang/gcc5. >> Architectures still stuck with base GCC (sparc64, powerpc*, mips*) are >> going to be BROKEN. And let's not forget users that prefer GCC over >> Clang for various reasons e.g., -Og, -flto, -fopenmp on i386, Graphite. >> > > Hello Jan, > > Thanks for pointing it out. > The section was added by zi@ with commit log "Fix build when using > FreeBSD older than 10.0". > > If this failure exists in all GCC prior to 6.x, I guess the solution would > looks like (not tested yet): > > Index: Makefile > =================================================================== > --- Makefile (revision 430546) > +++ Makefile (working copy) > @@ -48,8 +48,14 @@ > LZ4_LIB_DEPENDS= liblz4.so:archivers/liblz4 > ZSTD_LIB_DEPENDS= libzstd.so:archivers/zstd > > +USES+= compiler:features > + > Ah, this should not be added. > .include > > +.if ${COMPILER_TYPE} == gcc && ${COMPILER_VERSION} <= 60 > +CFLAGS+= -D_GLIBCXX_USE_C99 > +.endif > + > .if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 36 > CXXFLAGS+= -Wno-inconsistent-missing-override > .endif > > Regards, > sunpoet > > >> $ uname -rp >> 12.0-CURRENT amd64 >> $ pkg install -qy gcc >> $ make clean all CC=gcc49 CXX=g++49 CPP=cpp49 >> [...] >> util/options_helper.cc: In function 'uint64_t rocksdb::ParseUint64(const >> string&)': >> util/options_helper.cc:260:18: error: 'stoull' is not a member of 'std' >> uint64_t num = std::stoull(value.c_str(), &endchar); >> ^ >> util/options_helper.cc: In function 'int rocksdb::{anonymous}::ParseInt(const >> string&)': >> util/options_helper.cc:378:13: error: 'stoi' is not a member of 'std' >> int num = std::stoi(value.c_str(), &endchar); >> ^ >> util/options_helper.cc: In function 'double rocksdb::{anonymous}::ParseDouble(const >> string&)': >> util/options_helper.cc:416:10: error: 'stod' is not a member of 'std' >> return std::stod(value); >> ^ >> util/options_helper.cc:420:1: warning: control reaches end of non-void >> function [-Wreturn-type] >> } >> ^ >> _______________________________________________ >> svn-ports-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-ports-all >> To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" >> > >