From owner-freebsd-current@FreeBSD.ORG  Mon Sep 22 12:10:12 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C98087B3;
 Mon, 22 Sep 2014 12:10:12 +0000 (UTC)
Received: from mailout06.t-online.de (mailout06.t-online.de [194.25.134.19])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mailout00.t-online.de",
 Issuer "TeleSec ServerPass DE-1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 865B7C2E;
 Mon, 22 Sep 2014 12:10:12 +0000 (UTC)
Received: from fwd16.aul.t-online.de (fwd16.aul.t-online.de [172.20.26.243])
 by mailout06.t-online.de (Postfix) with SMTP id 1DF7F44D460;
 Mon, 22 Sep 2014 14:10:04 +0200 (CEST)
Received: from [192.168.119.10]
 (XLtQT6ZAQh5vn+3boH63ziuZO38FWvsFKxcBhmIhzQGlLwXHcU30Dyvlfihfw0hgnj@[84.154.118.168])
 by fwd16.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-SHA encrypted)
 esmtp id 1XW2RJ-0rEt5E0; Mon, 22 Sep 2014 14:09:57 +0200
Message-ID: <54201192.5080906@freebsd.org>
Date: Mon, 22 Sep 2014 14:09:54 +0200
From: Stefan Esser <se@freebsd.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Gyrd Thane Lange <gyrd-se@thanelange.no>, 
 freebsd-current@freebsd.org
Subject: Re: [patch] syscons/vt keymap: Norwegian country code conflicts with
 default value
References: <20140921183936.03617590@onyx.thanelange.no>
In-Reply-To: <20140921183936.03617590@onyx.thanelange.no>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-ID: XLtQT6ZAQh5vn+3boH63ziuZO38FWvsFKxcBhmIhzQGlLwXHcU30Dyvlfihfw0hgnj
X-TOI-MSGID: 514bd1c8-1bb9-4619-9413-10a360754b0b
Cc: freebsd-stable stable <freebsd-stable@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Sep 2014 12:10:12 -0000

Am 21.09.2014 um 18:39 schrieb Gyrd Thane Lange:
> Hi,
> 
> Recent changes in keymap namning for syscons/vt to use shorter names
> has exposed a conflict with the value "no" both used as country code
> for Norway and as a default value indicating that no keymap is set.
> 
> The attached patch proposes to use "" (empty string) as default value
> instead.

Hi Gyrd,

thank you for reporting the issue!

I have just committed a slightly different patch to -CURRENT and plan
to merge it to 10-STABLE in time for the next BETA.

You may want to check-out r271958 ...


The approach I have chosen it to let "NO" continue to stand for "do
not load any keymap", while "no" is now recognized as equivalent to
"no.kbd".


The new semantics of the keymap parameter in rc.conf are:

	keymap='' ==> do not load any keymap (unchanged)
	keymap=NO ==> do not load any keymap (unchanged)
	keymap=no ==> load Norwegian keymap  (new)

This may still catch people that have edited rc.conf to use "no" in
the meaning "no keymap" by accident, but I see no other approach that
better complies with POLA ...

An alternative to a MFC to 10-STABLE (and 10.1) might be to mention
this specific case in the release notes (and to suggest "keymap=no.kbd"
as a work-around). But I'll try to get approval for the MFC in time for
10.1-BETA3 ...

Regards, STefan