Date: Fri, 10 Apr 2015 18:08:03 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, Dmitry Marakasov <amdmi3@amdmi3.ru>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <552784E3.8020401@FreeBSD.org> In-Reply-To: <20150409162416.GA54797@FreeBSD.org> References: <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org> <55269FE4.2030208@FreeBSD.org> <20150409160330.GB31951@FreeBSD.org> <5526A52E.4090801@FreeBSD.org> <20150409162416.GA54797@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/04/2015 2:24 AM, Alexey Dokuchaev wrote: > On Thu, Apr 09, 2015 at 11:13:34AM -0500, Bryan Drewery wrote: >> On 4/9/2015 11:03 AM, Alexey Dokuchaev wrote: >>> On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote: >>>> Read the commit log again for r369644. Setting one var and not the other >>>> leads to incorrect behavior in many ports. You must have them matching. >>>> It is not just about jails/chroots. >>> >>> I've (re)read it and understand what you're trying to accomplish; my point >>> here is not to *build* things against custom OSVERSION, but just check if >>> some variables are set correctly, e.g. "make -V FOO OSVERSION=xxx" is what >>> I miss. Is there a way to allow it again somehow? >> >> I understand what you're trying to do and I agree it would be useful if >> it worked. Validating port logic (such as whether EXTRA_PATCHES has >> something) based on OSVERSION is very useful. I'll think about how to >> fix it. > > Right, EXTRA_PATCHES is a very good example. Good to know that there is > mutual understanding now and a chance for a fix. :) Thanks, > > ./danfe > +1 I've found myself many times debugging an individual port or ports framework logic issue checking everything is as it should be. Thank you Bryan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?552784E3.8020401>