From owner-svn-src-head@freebsd.org Mon Apr 10 17:42:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 249EAD3721D; Mon, 10 Apr 2017 17:42:40 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-pf0-x234.google.com (mail-pf0-x234.google.com [IPv6:2607:f8b0:400e:c00::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E7243CBD; Mon, 10 Apr 2017 17:42:39 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-pf0-x234.google.com with SMTP id i5so36585977pfc.2; Mon, 10 Apr 2017 10:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=BODPESfqF0rhFUOGYI+n6EecFVSVMKS6Sf+IWETZeRs=; b=Y3wiXOvgISkbRxRbATYFcXWAQphnmTeILCn+vW+3AkQ4p67Prosgoch8Htie2gfW14 7SQCkSLvTC0Zm7X3HxcFHEw4Cg/dNY9LPc5xP4BwTf8Mdf9kKkEN2d6x8pMF80Vg1tr1 5EZf2Cir4UM9411Pmob8S9nYnYYMexjH7gGAZzYEnsm3spTo7+G1mMBlVnKCyBKH/VNJ MTEVYu0sLhYT0ympC3rqvJCVChoCZU77GCiukdvezDH0TPnR5IkgGIvOoTYaPOH7ydZQ eEsJqOSWKpfRl2ovaCY1qxXbo578cFdFX9djYA6xo56KKMJXXgXrSqzOny80dNLXC+SW XPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=BODPESfqF0rhFUOGYI+n6EecFVSVMKS6Sf+IWETZeRs=; b=T/w3fd/0w4SV4yYF4AGSKSgCeIBPBTJ1pjvmrDdRkSRLbDCmzFQNUwOBSRMVJyYDcl NM3hynat79laC1hHjqGQxpQJPifK/kONzdz1viJQwBiwfT6nAA0Lq9l6vvU0TwZMgUEj tzTHtZitWjWU257lRveqEHw2qS5p7huLkxCgBA7SKF/FWMUJRhAdRcCydfxfBTV3pEcF jFLWZ7HF7iUbwn5XNjHu9sBccgLPOagWrZD0ajn7aAM2AZiV3Y+RsARonbGRdBvfJduv fSsTS5PB/+TN11avy0FddUwXHpEFHQGD/52thLlCAHlzgGzY8Mxl/Y6FVRLlxxIcObf/ R4AQ== X-Gm-Message-State: AFeK/H2OB3MWswoV6Bh+F2usBsdcd8mzBtC5gZQPFi5xnK1IRvq8Il+mEZ4uTk86YoaRJ8V0fNLn96Sj+CXfGw== X-Received: by 10.99.117.8 with SMTP id q8mr50861553pgc.106.1491846159301; Mon, 10 Apr 2017 10:42:39 -0700 (PDT) MIME-Version: 1.0 Sender: pkelsey@gmail.com Received: by 10.100.162.34 with HTTP; Mon, 10 Apr 2017 10:42:38 -0700 (PDT) In-Reply-To: <7472f248-0dac-dd6c-da91-25e579e0631e@FreeBSD.org> References: <201704090200.v39203Vf072867@repo.freebsd.org> <0da40261-7829-8d63-c4aa-775a028367a2@FreeBSD.org> <7472f248-0dac-dd6c-da91-25e579e0631e@FreeBSD.org> From: Patrick Kelsey Date: Mon, 10 Apr 2017 13:42:38 -0400 X-Google-Sender-Auth: OlQ6dq6ECd_YtXrhcQG_WqggVCE Message-ID: Subject: Re: svn commit: r316648 - in head/sys: amd64/amd64 amd64/include arm/arm arm/include arm64/include cddl/dev/dtrace/aarch64 cddl/dev/dtrace/amd64 cddl/dev/dtrace/arm cddl/dev/dtrace/i386 cddl/dev/dtrace... To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 17:42:40 -0000 On Mon, Apr 10, 2017 at 1:26 PM, Jung-uk Kim wrote: > On 04/10/2017 13:23, Jung-uk Kim wrote: > > On 04/08/2017 22:00, Patrick Kelsey wrote: > >> Author: pkelsey > >> Date: Sun Apr 9 02:00:03 2017 > >> New Revision: 316648 > >> URL: https://svnweb.freebsd.org/changeset/base/316648 > >> > >> Log: > >> Corrected misspelled versions of rendezvous. > >> > >> The MFC will include a compat definition of smp_no_rendevous_barrier() > >> that calls smp_no_rendezvous_barrier(). > >> > >> Reviewed by: gnn, kib > >> MFC after: 1 week > >> Differential Revision: https://reviews.freebsd.org/D10313 > > ... > > > > We knew about the problem but we didn't fix it because it breaks KPI. > > For example, sysutils/virtualbox-ose-kmod. If you really want to MFC > > this change, you have to implement shims. > > Actually, I meant to say current also needs a shim. Otherwise, > _FreeBSD_version must be bumped. > > Sorry, I wasn't clear about this. > > I'm glad you clarified, as I was reading your last message just now wondering what I was missing. With respect to current, the intention is for the misspelled version to be gone in 12. The lack of a version bump was due to my misunderstanding of whether KPI changes were or weren't being tracked in __FreeBSD_version prior to a .0 release, but now that I've gone and found 1.6 in the Porter's Handbook, it's clear that they are. Thanks for catching this. -Patrick