From nobody Tue Feb 28 23:04:48 2023
X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRCck68thz3v48p
	for <freebsd-git@mlmmj.nyi.freebsd.org>; Tue, 28 Feb 2023 23:04:54 +0000 (UTC)
	(envelope-from brooks@spindle.one-eyed-alien.net)
Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4PRCck4GGvz4FFy;
	Tue, 28 Feb 2023 23:04:54 +0000 (UTC)
	(envelope-from brooks@spindle.one-eyed-alien.net)
Authentication-Results: mx1.freebsd.org;
	none
Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001)
	id AD9DC3C0199; Tue, 28 Feb 2023 23:04:48 +0000 (UTC)
Date: Tue, 28 Feb 2023 23:04:48 +0000
From: Brooks Davis <brooks@freebsd.org>
To: Ed Maste <emaste@freebsd.org>
Cc: Warner Losh <imp@bsdimp.com>, freebsd-git <freebsd-git@freebsd.org>
Subject: Re: Report on the pull request experiment so far
Message-ID: <Y/6IkCD+5YawlCHX@spindle.one-eyed-alien.net>
References: <CANCZdfoOm3iWZHvh6oy4Cj6qpcvnHjAWpbvNp7r9msfwO_r5fg@mail.gmail.com>
 <CAPyFy2D7MBsThAUYkVyh1Tg3UW8mAvBXL5wwmSKjpSsHFm5y1Q@mail.gmail.com>
List-Id: Discussion of git use in the FreeBSD project <freebsd-git.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-git
List-Help: <mailto:freebsd-git+help@freebsd.org>
List-Post: <mailto:freebsd-git@freebsd.org>
List-Subscribe: <mailto:freebsd-git+subscribe@freebsd.org>
List-Unsubscribe: <mailto:freebsd-git+unsubscribe@freebsd.org>
Sender: owner-freebsd-git@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAPyFy2D7MBsThAUYkVyh1Tg3UW8mAvBXL5wwmSKjpSsHFm5y1Q@mail.gmail.com>
X-Rspamd-Queue-Id: 4PRCck4GGvz4FFy
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On Tue, Feb 28, 2023 at 05:12:37PM -0500, Ed Maste wrote:
> On Sat, 25 Feb 2023 at 18:54, Warner Losh <imp@bsdimp.com> wrote:
> >
> > I also landed one commit that was from 2021. Yikes. The commit date is =
right, but the author date is in the past. I suggest that we add a git comm=
it --amend --date=3D"`date`" to the process. This likely is a good thing. T=
here's no simple --reset-date, alas: only a reset that also resets the auth=
or.
>=20
> IMO we should just accept git's notion of separate author and commit
> dates, and not worry about author dates being in the past.

I remain on the fence, but think we should either accept git's notion or
enforce that the date is newer than prior commits and not in the future.
IMO we should enforce this on commit dates regardless[0].  There is no
conceivable value in allowing people to commit from systems with wildly
wrong clocks given they must be on the internet to commit.

-- Brooks

[0] Obviously this only applies to first-parent commits not the commits
being merged in a merge commit.