From owner-cvs-all Sat Apr 6 20:38:18 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 553F437B419; Sat, 6 Apr 2002 20:38:13 -0800 (PST) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g374c3x7062769; Sun, 7 Apr 2002 08:38:10 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.2/8.12.2/Submit) id g374c26E062768; Sun, 7 Apr 2002 08:38:02 +0400 (MSD) Date: Sun, 7 Apr 2002 08:38:01 +0400 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/sort init.c sort.c Message-ID: <20020407043800.GA62669@nagual.pp.ru> References: <200204070049.g370n1G28853@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Apr 07, 2002 at 06:30:18 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" writes: > > Log: > > Original code bugfixed. This NOT touch old sorting order a bit. > > > > 1) Remove \n from COPYRIGHT macro to shut up assembler warning > > 2) Fix struct sigaction initialization (arguments swap) > > 3) Fix out of bounds negative indexing for -R arg > 127 > > 4) Remove doubled initialization of vars already initialized statically > > 5) Convert ctype macros char arg to u_char to prevents sign extension > > Is there any reason why these patches could not first have been > contributed to NetBSD? Yes. Time limit. It was mark's idea to activate NetBSD sort by default, not mine. It should not be activated by my opinion. Once it is activated, I am in the time limit fixing its l10n because it is far more important in everyday sort's usage that having identical sorts. I can't work at the l10n fixes and be involved in the back contribute message exchange in the same time. At this moment I have some completely different approach about it, wait for the next my message. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message