Date: Fri, 21 Dec 2012 15:18:35 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r309343 - in head/archivers/fastjar: . files Message-ID: <CAOfEmZgSq5ZAGeWx0V=S-mZP9amxZKfcTGEv97RtYhG_z59pFA@mail.gmail.com> In-Reply-To: <201212210709.qBL793Pf011937@svn.freebsd.org> References: <201212210709.qBL793Pf011937@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2012/12/21 Alexey Dokuchaev <danfe@freebsd.org> > > > Approved by: maintainer (maho) > > Dear Alexey, What I'm going to point out is not so important, but as I know that you like and keep attention of standards and details, I think you shall follow the Approved by, using the same standard as for mentor. Approved by: maho (maintainer) instead of Approved by: maintainer (maho) Here is a description from Committers Guide: """ Approved by: The name and e-mail address of the person or people that approved the change; for committers, just the username on the FreeBSD cluster. It is customary to get prior approval for a commit if it is to an area of the tree to which you do not usually commit. In addition, during the run up to a new release all commits *must*be approved by the release engineering team. If these are your first commits then you should have passed them past your mentor first, and you should list your mentor, as in ``* username-of-mentor* (mentor)''. """ Best Regards, -- Marcelo Araujo araujo@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZgSq5ZAGeWx0V=S-mZP9amxZKfcTGEv97RtYhG_z59pFA>