From owner-freebsd-net@FreeBSD.ORG  Mon Jun 11 05:17:48 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6673A1065670;
	Mon, 11 Jun 2012 05:17:48 +0000 (UTC)
	(envelope-from gperez@entel.upc.edu)
Received: from violet.upc.es (violet.upc.es [147.83.2.51])
	by mx1.freebsd.org (Postfix) with ESMTP id DBD0F8FC16;
	Mon, 11 Jun 2012 05:17:47 +0000 (UTC)
Received: from entelserver.upc.edu (entelserver.upc.es [147.83.39.4])
	by violet.upc.es (8.14.1/8.13.1) with ESMTP id q5B5HePd022802;
	Mon, 11 Jun 2012 07:17:41 +0200
Received: from webmail.entel.upc.edu (wireless.upc.es [147.83.39.6])
	by entelserver.upc.edu (Postfix) with ESMTP id B1C202CBD18;
	Mon, 11 Jun 2012 07:17:35 +0200 (CEST)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Mon, 11 Jun 2012 07:17:35 +0200
From: Gustau Perez Querol <gperez@entel.upc.edu>
To: Andrew Thompson <thompsa@freebsd.org>
In-Reply-To: <CAFAOGNRdNDV3JooR5hMjtD1W+8BkZU0U_8=CZLFgyimft6VEog@mail.gmail.com>
References: <c3457a59051eba45d2204aa1fb7388db@webmail.entel.upc.edu>
	<CAFAOGNRdNDV3JooR5hMjtD1W+8BkZU0U_8=CZLFgyimft6VEog@mail.gmail.com>
Message-ID: <3ef7f25e2c85a10266421a7e120d73c2@webmail.entel.upc.edu>
X-Sender: gperez@entel.upc.edu
User-Agent: RoundCube Webmail/0.5.1
X-Mail-Scanned: Criba 2.0 + Clamd
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0
	(violet.upc.es [147.83.2.51]);
	Mon, 11 Jun 2012 07:17:41 +0200 (CEST)
Cc: net@freebsd.org
Subject: Re: Panic with if_bridge when removing components
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2012 05:17:48 -0000

On Mon, 11 Jun 2012 08:49:29 +1200, Andrew Thompson wrote:
> On 10 June 2012 02:27, Gustau Perez Querol <gperez@entel.upc.edu> 
> wrote:
>>  Hi,
>>
>>  I'm seeing panics when removing an interface of a bridge. The 
>> system runs
>> HEAD/AMD64 r236733. I see no changes to if_bridge.c in the last two 
>> days, so
>> I would say the problem's still there. I also checked stable and the 
>> problem
>> should be there too.
>>
>>  The problem is that I have a bridge composed of two ethernet 
>> interfaces, an
>> ath interface and a tap. As soon as I remove any of them the system 
>> panics.
>> Because the system runs openvpn with the tap connected to the 
>> bridge, when
>> the system starts to reboot, the openvpn daemon removes the tap and 
>> thus
>> causing also the panic.
>>
>>  The panic comes because at sys/net/if_bridge.c:943 the struct
>> *ifnet->if_bridge of the interface removed is set to NULL too early. 
>> Because
>> of this, at sys/net/if_bridge.c:996 we call 
>> if_bridge.c:bridge_linkstate
>> where the struct *ifnet->if_bridge is needed. This causes the panic.
>
>
> I introduced this issue in r234487, please try this patch.
> http://people.freebsd.org/~thompsa/bridge_link.diff
>
> regards,
> Andrew


   I'll check this evening (if time permits) and report back.