From owner-freebsd-current  Tue Oct 24  8:55:49 2000
Delivered-To: freebsd-current@freebsd.org
Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147])
	by hub.freebsd.org (Postfix) with ESMTP id D1EA737B479
	for <current@freebsd.org>; Tue, 24 Oct 2000 08:55:46 -0700 (PDT)
Received: from critter (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.1/8.9.3) with ESMTP id e9OG4mU20335
	for <current@freebsd.org>; Tue, 24 Oct 2000 18:04:48 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: current@freebsd.org
Subject: Review: offsetof/<struct.h>/fldoff patch.
From: Poul-Henning Kamp <phk@freebsd.org>
Date: Tue, 24 Oct 2000 18:04:48 +0200
Message-ID: <20333.972403488@critter>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


Please test & review this patch:

	http://phk.freebsd.dk/patch/offsetof.patch

-----------------
Define offsetof() in <sys/types.h> for the kernel and in <stddef.h>
for userland.

#ifdef the definition in <stddef.h> and <sys/types.h> so that
we don't need N identical definitions in <machine/ansi.h> but
still allow for a MD definition there should need be.

Use offsetof() instead of fldoff()

Remove nested include of <struct.h> from <sys/queue.h>

Remove local definitions of offsetof().

Deprecate <struct.h>
-----------------

Files affected:

Index: include/stddef.h
Index: include/struct.h
Index: sys/alpha/alpha/machdep.c
Index: sys/dev/aac/aac.c
Index: sys/dev/aac/aacvar.h
Index: sys/dev/mly/mly.c
Index: sys/dev/sym/sym_hipd.c
Index: sys/dev/wds/wd7000.c
Index: sys/i386/i386/machdep.c
Index: sys/ia64/ia64/machdep.c
Index: sys/kern/sysv_sem.c
Index: sys/kern/uipc_usrreq.c
Index: sys/net/if_stf.c
Index: sys/netinet/in_gif.c
Index: sys/netinet6/frag6.c
Index: sys/netinet6/icmp6.c
Index: sys/netinet6/in6_gif.c
Index: sys/netinet6/in6_proto.c
Index: sys/netinet6/raw_ip6.c
Index: sys/netkey/key.c
Index: sys/pc98/i386/machdep.c
Index: sys/sys/queue.h
Index: sys/sys/types.h

--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message