Date: Fri, 1 Apr 2016 14:56:19 +0200 From: Erwin Lansing <erwin@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Thomas Zander <riggs@freebsd.org>, Jan Beich <jbeich@freebsd.org>, "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, portmgr@freebsd.org Subject: Re: svn commit: r412296 - head/lang/rust Message-ID: <A4E7B68E-B5EB-41E5-B4BB-B9D58D663A7C@FreeBSD.org> In-Reply-To: <E207BCC9DD7103BC81BCD8B8@ogg.in.absolight.net> References: <201603312004.u2VK4n5n028013@repo.freebsd.org> <CAFU734wN13GQnHuXHQ_sW97v9%2Bq3TSYyZPHiqLTjq5HYwO=SAQ@mail.gmail.com> <C4C464C799DD4405CCC76990@atuin.in.mat.cc> <CAFU734xGcOuzH%2BbSNMZw6M8a5GYZkdSD11L8-h_T9W2zge18jg@mail.gmail.com> <E207BCC9DD7103BC81BCD8B8@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_0DABE711-9C11-4CEE-ABB4-3CDE9FE16680 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 01 Apr 2016, at 15:06, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 > +--On 1 avril 2016 12:05:47 +0200 Thomas Zander <riggs@freebsd.org> = wrote: > | On 1 April 2016 at 11:45, Mathieu Arnold <mat@freebsd.org> wrote: > | > |> It is documented in the porter's handbook, where it all belongs: > |> = <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintain > |> er.html> > |> > |> And, it is covered by the "Trivial and tested build and runtime = fixes." > |> bullet point. > | > | Thanks for stepping in, but I am a 100% sure that this statement = will > | not put the case to rest. Based on this statement: > | - John will maintain his position that this commit was trivial, = tested > | and fixes a problem *on DragonFly* and hence *is* covered by the > | blanket > | - I will maintain my position that this commit does *not* fix a > | problem *on FreeBSD* and hence is *not* covered by the blanket > | > | I am totally fine accepting any verdict from portmgr, but I want it = to > | be inescapably clear. Please review the commit and let us know once > | and for all: Is this particular one covered by the blanket or not? >=20 > *I* would say that you are right and it's not a FreeBSD fix, and thus, = is > not covered by the blanket. But I don't know what portmgr as a whole > thinks about it. Rather than nitpick what the rules say exactly, I=E2=80=99d take a step = back and consider how we like to work together. On the surface, it = indeed seems a trivial commit, but on the other hand the port has an = active maintainer, from whom a quick reply could be expected. Taken = together, I would have chosen to ask the maintainer first, out of = respect for the maintainer. In a similar situation, I would imagine = myself as the maintainer and how I would feel if I saw a commit happen = to my port and wonder why the change was so important it couldn=E2=80=99t = wait for me to have a look at it first. We have this great = technological platform, but in the end it=E2=80=99s the people that make = this project. Just because there is a rule or policy that might allow = one to do something, does not mean it=E2=80=99s the right thing to do. Erwin --Apple-Mail=_0DABE711-9C11-4CEE-ABB4-3CDE9FE16680 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJW/m/3AAoJEFF75hSlwe7HZoQH/i/ZL+Xh4E4IACM/+ygVz5A+ OT/9vKHPT65+Rfb5Y3ANxQILJZxrnz2cUyOnFpZELvyNak0sn+rOjFEWWpLLRR8x lmq5ChKM2F7NIv/22zXBGq5LW6NVj1+KuDZ/o7UnL7lbKIKxfamKGb0CzZwuQOLM iWKVetF80rRP5uNyy0Nnkk7MRsT0l+zGH0763JC64KxoZbhXgP4zQzlAYPvNbnWE uz6JgETAMAyN8Q2Pf6AlDV3JKcdL997WaYLuxeqABPjFnCO6XE946X7tI8VHQeBQ fkrTZxJ+ZHe3LrW8JLRHgLgp+2Qlu3jKLYurij/v7XRHl8cBJLtHDIfuRI2RQNw= =EcR0 -----END PGP SIGNATURE----- --Apple-Mail=_0DABE711-9C11-4CEE-ABB4-3CDE9FE16680--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A4E7B68E-B5EB-41E5-B4BB-B9D58D663A7C>