From owner-cvs-src@FreeBSD.ORG Mon Mar 31 17:02:04 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6ABB537B401; Mon, 31 Mar 2003 17:02:04 -0800 (PST) Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BCE943F85; Mon, 31 Mar 2003 17:02:03 -0800 (PST) (envelope-from jake@k6.locore.ca) Received: from k6.locore.ca (localhost.locore.ca [127.0.0.1]) by k6.locore.ca (8.12.8/8.12.8) with ESMTP id h3118YxS039878; Mon, 31 Mar 2003 20:08:34 -0500 (EST) (envelope-from jake@k6.locore.ca) Received: (from jake@localhost) by k6.locore.ca (8.12.8/8.12.8/Submit) id h3118Yeo039877; Mon, 31 Mar 2003 20:08:34 -0500 (EST) Date: Mon, 31 Mar 2003 20:08:33 -0500 From: Jake Burkholder To: Nate Lawson Message-ID: <20030401010833.GA39531@locore.ca> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2003 01:02:04 -0000 Apparently, On Mon, Mar 31, 2003 at 04:37:15PM -0800, Nate Lawson said words to the effect of; > On Mon, 31 Mar 2003, John Baldwin wrote: > > On 31-Mar-2003 John Baldwin wrote: > > > jhb 2003/03/31 12:22:00 PST > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c > > > if_ste.c if_tl.c if_vr.c if_wb.c if_xl.c > > > Log: > > > Add missing ()'s so that these drivers all compile again. > > > > > > Noticed by: jake > > > Tested on: i386 (compile) > > > > Also, the pcn(4) driver still has some possibly bogus locking in > > its probe routine. Not sure if other drivers have locks in their > > probe routines. > > Thank you jhb and jake for fixing the KASSERT ()'s. I had options > INVARIANTS in my kernel so I'm not sure why this was not caught. I was > compiling them as modules so does INVARIANTS not enable KASSERT in > modules? It does not, option headers and not created automatically for modules. Jake