From owner-svn-src-all@FreeBSD.ORG Sat Apr 3 11:42:28 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3887B1065672 for ; Sat, 3 Apr 2010 11:42:28 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from www.sonnenberger.org (www.sonnenberger.org [92.79.50.50]) by mx1.freebsd.org (Postfix) with ESMTP id ED94D8FC16 for ; Sat, 3 Apr 2010 11:42:27 +0000 (UTC) Received: from britannica.bec.de (www.sonnenberger.org [192.168.1.10]) by www.sonnenberger.org (Postfix) with ESMTP id 52F166665D for ; Sat, 3 Apr 2010 13:42:26 +0200 (CEST) Received: by britannica.bec.de (Postfix, from userid 1000) id C840715C64; Sat, 3 Apr 2010 13:40:55 +0200 (CEST) Date: Sat, 3 Apr 2010 13:40:55 +0200 From: Joerg Sonnenberger To: svn-src-all@freebsd.org Message-ID: <20100403114055.GC23007@britannica.bec.de> References: <201004011427.o31ERTaT056824@svn.freebsd.org> <20100402001231.GA16732@britannica.bec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 11:42:28 -0000 On Sat, Apr 03, 2010 at 04:32:15AM -0700, Garrett Cooper wrote: > I'm sorry but I'm a little bit confused by this statement: do you > mean that you're replacing PATH_MAX sized buffers to FILENAME_MAX > sized buffers? If so this may cause an issue because several of the > variables used in constructing the file paths in pkg_install aren't > necessarily correct in overflow cases. We need to avoid introducing > potential functional flaws with filename truncation like this. No, I am replacing fixed size buffers with variable size buffers. The extraction code should generally be able to support arbitrary deep path names, for the rest the kernel can complain. Joerg