From owner-freebsd-net Fri May 31 14: 0:35 2002 Delivered-To: freebsd-net@freebsd.org Received: from sccrmhc03.attbi.com (sccrmhc03.attbi.com [204.127.202.63]) by hub.freebsd.org (Postfix) with ESMTP id DDA2437B409 for ; Fri, 31 May 2002 14:00:24 -0700 (PDT) Received: from InterJet.elischer.org ([12.232.206.8]) by sccrmhc03.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020531210024.MSIN20219.sccrmhc03.attbi.com@InterJet.elischer.org>; Fri, 31 May 2002 21:00:24 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA29904; Fri, 31 May 2002 13:52:19 -0700 (PDT) Date: Fri, 31 May 2002 13:52:18 -0700 (PDT) From: Julian Elischer To: Archie Cobbs Cc: Bosko Milekic , freebsd-net@FreeBSD.ORG Subject: Re: m_split() considered harmful In-Reply-To: <200205312025.g4VKP9t02205@arch20m.dellroad.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Fri, 31 May 2002, Archie Cobbs wrote: > > It's not clear whether the caller of M_TRAILINGSPACE()/M_LEADINGSPACE() > is responsible for checking for writability, or the macros themselves. > It seems to make more sense that the caller would be responsible... > why would you call M_TRAILINGSPACE() unless you wanted to write > something in there? > M_TRAILINGSPACE is called to ask "How much writable room is there after hte data here? if the module is not writable the answer should always be "none". your patch looks better now I'm wouldering however if any code other than that looks at ext_size To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message