From owner-cvs-ports@FreeBSD.ORG  Mon Jul  7 17:54:58 2008
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3871C1065677;
	Mon,  7 Jul 2008 17:54:58 +0000 (UTC)
	(envelope-from gahr@FreeBSD.org)
Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73])
	by mx1.freebsd.org (Postfix) with ESMTP id E35798FC1C;
	Mon,  7 Jul 2008 17:54:57 +0000 (UTC)
	(envelope-from gahr@FreeBSD.org)
Received: from [213.142.183.219] (helo=gahrtop.localhost)
	by cpanel03.rubas-s03.net with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.68) (envelope-from <gahr@FreeBSD.org>)
	id 1KFuvR-0006X6-3I; Mon, 07 Jul 2008 19:54:57 +0200
Message-ID: <4872586B.3010706@FreeBSD.org>
Date: Mon, 07 Jul 2008 19:54:51 +0200
From: Pietro Cerutti <gahr@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Thunderbird 2.0.0.14 (X11/20080610)
MIME-Version: 1.0
To: Max Khon <fjoe@samodelkin.net>
References: <200807071617.m67GHsHA058914@repoman.freebsd.org>
	<48724635.80406@FreeBSD.org> <487251C7.7060102@samodelkin.net>
In-Reply-To: <487251C7.7060102@samodelkin.net>
X-Enigmail-Version: 0.95.6
OpenPGP: id=9571F78E;
	url=http://gahr.ch/pgp/
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - cpanel03.rubas-s03.net
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - FreeBSD.org
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Cc: Max Khon <fjoe@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/dmucs Makefile ports/devel/dmucs/files
 patch-dmucs_db.cc patch-dmucs_db.h patch-dmucs_msg.cc patch-main.cc
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2008 17:54:58 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Max Khon wrote:
| Hello!

Hello!

|
| Pietro Cerutti wrote:
|
|> -----BEGIN PGP SIGNED MESSAGE-----
|> Hash: SHA512
|>
|> Max Khon wrote:
|> | fjoe        2008-07-07 16:17:54 UTC
|> |
|> |   FreeBSD ports repository
|> |
|> |   Modified files:
|> |     devel/dmucs          Makefile
|> |   Added files:
|> |     devel/dmucs/files    patch-dmucs_db.cc patch-dmucs_db.h
|> |                          patch-dmucs_msg.cc patch-main.cc
|> |   Log:
|> |   Unbreak on 64-bit archs
|>
|> I definitely do not agree. Please note that a pointer is not required to
|> fit into a long, while it is required to fit into a size_t.
|>
|> Your solution may work as soon as we are concerned only with LP64
|> machines. As soon as a LLP64 arch steps in, you break things.
|
| AFAIK it is not guaranteed that sizeof(void *) <= sizeof(size_t) too.
| I used "long" because I did not want to cope with "[u]intptr_t" there.
|
| Ok, I committed a modified patch that uses "const void *" instead of
| "long".

You are right (see my follow-up to ports@). Anyway, it seems to be ok now :)

|
| /fjoe


- --
Pietro Cerutti
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEAREKAAYFAkhyWGoACgkQwMJqmJVx945UEACfa59PMGHy+m2ANLohTgqKm5Zu
HhcAoMlrXByiwIyt85VPEramaYeDsz64
=RLu9
-----END PGP SIGNATURE-----